Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when creating groups from the user list. #5751

Closed
jzawer opened this issue Jul 17, 2017 · 5 comments · Fixed by #8824
Closed

Errors when creating groups from the user list. #5751

jzawer opened this issue Jul 17, 2017 · 5 comments · Fixed by #8824
Assignees
Labels
3. to review Waiting for reviews bug feature: users and groups good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Milestone

Comments

@jzawer
Copy link

jzawer commented Jul 17, 2017

Steps to reproduce

  1. Login as Administrator.
  2. Go to Users.
  3. On one user add a new group.
  4. In left panel, the new group appear twice.

Expected behaviour

When you create group from user you should see only once in left panel.

Actual behaviour

When you create group from user you see the new group twice.

grupoduplicado

Server configuration.

Nextcloud version: 12

@MorrisJobke MorrisJobke added bug feature: users and groups good first issue Small tasks with clear documentation about how and in which place you need to fix things in. labels Aug 29, 2017
@rpirritano
Copy link
Contributor

@MorrisJobke,
I am a new contributor, if this is still available, I can take it?

@MorrisJobke
Copy link
Member

@MorrisJobke,
I am a new contributor, if this is still available, I can take it?

Hi @rpirritano sure :) If you have questions, feel free to ask here or go to our IRC channel #nextcloud-dev on freenode.

@rpirritano
Copy link
Contributor

@MorrisJobke ,

Quick question from investigating the issue. It seems that addGroup is being called twice in the multiSelect (users.js line 500). After the createCallback: addGroup is called, addGroup is then called again from the oncheck: addUserToGroup. Any information to why addUserToGroup is running addGroup again?

@MorrisJobke
Copy link
Member

Any information to why addUserToGroup is running addGroup again?

@blizzz Do you know more on this one?

@blizzz
Copy link
Member

blizzz commented Dec 4, 2017

@blizzz Do you know more on this one?

Not by heart, but it does not sound right. Perhaps it is a side effect cause by some other changes on the road.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug feature: users and groups good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants