Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Unable to enable server-side encryption #43123

Closed
4 of 8 tasks
ChristophWurst opened this issue Jan 25, 2024 · 2 comments · Fixed by #44604
Closed
4 of 8 tasks

[Bug]: Unable to enable server-side encryption #43123

ChristophWurst opened this issue Jan 25, 2024 · 2 comments · Fixed by #44604
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 29-feedback bug feature: encryption (server-side) regression
Milestone

Comments

@ChristophWurst
Copy link
Member

⚠️ This issue respects the following points: ⚠️

Bug description

image

TypeError: Object.entries(...).find(...) is undefined
    data Encryption.vue:113
    VueJS 6
    93952 main-admin-security.js:51
    Webpack 5
vue.runtime.esm.js:3065:16
    VueJS 8
    93952 main-admin-security.js:51
    Webpack 5

Steps to reproduce

  1. Install nextcloud
  2. Enable the default encryption app
  3. Go to admin security settings
  4. Enable server encryption
  5. A toast pops up telling me to enable encryption in the admin settings (that is what I am doing?)
  6. Reload the page

Expected behavior

I can enable server side encryption

Installation method

None

Nextcloud Server version

master

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@ChristophWurst ChristophWurst added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap regression feature: encryption (client-side) labels Jan 25, 2024
@ChristophWurst
Copy link
Member Author

On stable28 I was able to enable encryption. The flow is as follows:

Bildschirmfoto vom 2024-01-25 17-30-32
Bildschirmfoto vom 2024-01-25 17-30-42
Bildschirmfoto vom 2024-01-25 17-30-50
Bildschirmfoto vom 2024-01-25 17-30-54

@ChristophWurst ChristophWurst added this to the Nextcloud 29 milestone Jan 30, 2024
joshtrichards added a commit that referenced this issue Apr 1, 2024
Fixes #44532 
Helps with #43123 

Also adds a warning so that people aren't confused when the "Enable server-side encryption" toggle can't be toggled anymore after encryption is enabled.

Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards added a commit that referenced this issue Apr 1, 2024
Fixes #44532 
Likely fixes #43123 

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
Copy link
Member

joshtrichards commented Apr 1, 2024

The underlying cause for what you experienced is likely the same as #44532. It's a front-end bug. It'll break in <master too. The initial value is fine, but if Default encryption module gets clicked it breaks. The console error starts kicks in at that point. (In some scenarios the "Enable server-side encryption" radio button also switches off upon a page reload). It is impossible for the admin to fix in the Web UI - and it'll appear that the default encryption module is still selected even though it really isn't. Easily fixed via occ:

occ encryption:set-default-module OC_DEFAULT_MODULE

(but it'll break again if you touch the UI).

Bogus value is visible under occ config:list core (if default_encryption_module == yes then you triggered the bug).

The toast itself may be related or another matter. To be determined. In any case, been a bug likely since NC25 from the looks of it. PR #44604 remedies it.

backportbot bot pushed a commit that referenced this issue Apr 3, 2024
Fixes #44532

Likely fixes #43123

Signed-off-by: Josh <josh.t.richards@gmail.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

[skip ci]
backportbot bot pushed a commit that referenced this issue Apr 3, 2024
Fixes #44532

Likely fixes #43123

Signed-off-by: Josh <josh.t.richards@gmail.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

[skip ci]
backportbot bot pushed a commit that referenced this issue Apr 3, 2024
Fixes #44532
Likely fixes #43123

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command pushed a commit that referenced this issue Apr 3, 2024
Fixes #44532

Likely fixes #43123

Signed-off-by: Josh <josh.t.richards@gmail.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command pushed a commit that referenced this issue Apr 3, 2024
Fixes #44532

Likely fixes #43123

Signed-off-by: Josh <josh.t.richards@gmail.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
artonge pushed a commit that referenced this issue Apr 3, 2024
Fixes #44532

Likely fixes #43123

Signed-off-by: Josh <josh.t.richards@gmail.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge pushed a commit that referenced this issue Apr 3, 2024
Fixes #44532

Likely fixes #43123

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge added a commit that referenced this issue Apr 3, 2024
Fixes #44532

Likely fixes #43123

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge added a commit that referenced this issue Apr 4, 2024
Fixes #44532

Likely fixes #43123

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 29-feedback bug feature: encryption (server-side) regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants