Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV] Header bar a11y issues #33741

Closed
8 tasks done
PVince81 opened this issue Aug 29, 2022 · 5 comments
Closed
8 tasks done

[BITV] Header bar a11y issues #33741

PVince81 opened this issue Aug 29, 2022 · 5 comments
Assignees
Labels
Milestone

Comments

@PVince81
Copy link
Member

PVince81 commented Aug 29, 2022

Need to recheck those for #33728 @juliushaertl @CarlSchwan

@PVince81 PVince81 added 1. to develop Accepted and waiting to be taken care of accessibility labels Aug 29, 2022
@PVince81 PVince81 added this to the Nextcloud 25 milestone Aug 29, 2022
@juliusknorr juliusknorr self-assigned this Aug 29, 2022
@juliusknorr
Copy link
Member

Checked everything that is addressed in the above PR.

Keyboard focus overlaps with text

I've been talking with @jancborchardt about this already, but we don't have a good idea how to solve that nicely yet.

Logo link should not be h1, but rather have aria-label="to Nextcloud landing page"
h1 should instead be in the app content, ideally displayed visually

I'll keep this separate from the app menu pr to get it in more quickly for the UI redesign.

app content however might not be suitable as it is replaced by any vue app, if we need it in the content, we need some concept how that would look for the individual apps first @jancborchardt

@juliusknorr juliusknorr removed their assignment Aug 30, 2022
@juliusknorr juliusknorr mentioned this issue Aug 31, 2022
6 tasks
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Oct 19, 2022
@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Nov 11, 2022

  • Logo link should not be h1, but rather have aria-label="to Nextcloud landing page"

Logo link should not be h1

Already done in #35071

but rather have aria-label="to Nextcloud landing page"

aria-label is't needed because <img> has alt

@JuliaKirschenheuter

This comment was marked as duplicate.

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Nov 15, 2022
@jancborchardt

This comment was marked as duplicate.

@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Nov 16, 2022
@PVince81
Copy link
Member Author

closing as most are done

we continue to track the last task in #35201

JuliaKirschenheuter added a commit that referenced this issue Dec 1, 2022
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
ChristophWurst added a commit that referenced this issue Dec 20, 2022
…-Focused_item_overlaps_neighbor_elements_with_text_and_border

Add styles for #33741. Remove boards and add underlines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants