[Bug]: LDAP user and group backend causing frequent errors as of NC 24 #33622
Comments
Adambean
added
0. Needs triage
|
This appears to be regarding password policy attributes within the directory. Looking at "apps/user_ldap/lib/User/User.php" at line 672 we find this: An exception is being thrown here because In my case That alone is not enough as it only tries to re-fetch password policy attributes. That too could fail, in which case we need to handle if it does. After making that amend I can login with my LDAP account via web browser, and NextCloud for Windows immediately changed to a green tick. |
|
Here's how lines 664-678 should ideally look: Never submitted a PR before. I'll try that shortly. |
…tory not having password policy attributes available. nextcloud#33622 Signed-off-by: Adam Reece <adam@reece.wales>
|
Hello, Exception: array_key_exists(): Argument #2 ($array) must be of type array, null given in file '/var/www/html/nextcloud/do.do.fr/apps/user_ldap/lib/User/User.php' line 653 And i request error when i try login. |
|
I was tearing my hair out trying to find and work out this bug too. As best as I can figure, the unhandled exception was happening in our case because our LDAP server default policy does not include any of the For those that want a quick temporary fix: I added an arbitrary value for |
|
Hi, please update to 25.0.7 or better 26.0.2 and report back if it fixes the issue. Thank you! My goal is to add a label like e.g. 26-feedback to this ticket of an up-to-date major Nextcloud version where the bug could be reproduced. However this is not going to work without your help. So thanks for all your effort! If you don't manage to reproduce the issue in time and the issue gets closed but you can reproduce the issue afterwards, feel free to create a new bug report with up-to-date information by following this link: https://github.com/nextcloud/server/issues/new?assignees=&labels=bug%2C0.+Needs+triage&template=BUG_REPORT.yml&title=%5BBug%5D%3A+ |
|
I've not noticed this problem recently. (Currently running NC 27.0.0.) |
|
I've not noticed this problem recently too. |
Bug description
Good afternoon,
The LDAP user and group backend functionality has been the source of a lot of errors recently as of updating to NC 24.
5HiSSTs2OKKG7whPwWY8is an example error when trying to login.9FxSJKzzOUbrq65IDsk8is an example error when trying to retrieve users or groups via the LDAP configuration wizard.drmZOACEwahqrtlOHPCfis an example error from the Windows NextCloud client.Steps to reproduce
Expected behavior
The LDAP user and group backend functionality to not produce the errors quoted.
Installation method
Community Manual installation with Archive
Operating system
Debian/Ubuntu
PHP engine version
PHP 8.0
Web server
Apache (supported)
Database engine version
MariaDB
Is this bug present after an update or on a fresh install?
Updated to a major version (ex. 22.2.3 to 23.0.1)
Are you using the Nextcloud Server Encryption module?
No. App disabled.
What user-backends are you using?
Configuration report
{ "system": { "instanceid": "***REMOVED SENSITIVE VALUE***", "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "cloud.internal.example.com" ], "datadirectory": "***REMOVED SENSITIVE VALUE***", "version": "24.0.4.1", "installed": true, "maintenance": false, "dbtype": "mysql", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbname": "***REMOVED SENSITIVE VALUE***", "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "mail_smtpmode": "sendmail", "mail_sendmailmode": "smtp", "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_domain": "***REMOVED SENSITIVE VALUE***", "ldapIgnoreNamingRules": false, "ldapProviderFactory": "OCA\\User_LDAP\\LDAPProviderFactory", "theme": "", "loglevel": 3, "mysql.utf8mb4": true, "overwrite.cli.url": "https:\/\/cloud.internal.example.com", "memcache.local": "\\OC\\Memcache\\APCu", "encryption.legacy_format_support": false, "encryption.key_storage_migrated": false, "twofactor_enforced": "true", "twofactor_enforced_groups": [ "Administrators", "admin" ], "twofactor_enforced_excluded_groups": [ "Guests", "Services", "Servers", "Compilers" ] } }List of activated Apps
Nextcloud Signing status
Nextcloud Logs
{ "reqId": "5HiSSTs2OKKG7whPwWY8", "level": 3, "time": "2022-08-19T15:47:15+00:00", "remoteAddr": "****::11", "user": "****-****-****-****", "app": "PHP", "method": "POST", "url": "/index.php/login", "message": "Undefined array key 0 at /var/www/cloud/apps/user_ldap/lib/User/User.php#672", "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:103.0) Gecko/20100101 Firefox/103.0", "version": "24.0.4.1", "exception": { "Exception": "Error", "Message": "Undefined array key 0 at /var/www/cloud/apps/user_ldap/lib/User/User.php#672", "Code": 0, "Trace": [{ "file": "/var/www/cloud/apps/user_ldap/lib/User/User.php", "line": 672, "function": "onError", "class": "OC\\Log\\ErrorHandler", "type": "::" }, { "file": "/var/www/cloud/lib/private/legacy/OC_Hook.php", "line": 106, "function": "handlePasswordExpiry", "class": "OCA\\User_LDAP\\User\\User", "type": "->" }, { "file": "/var/www/cloud/lib/private/Server.php", "line": 609, "function": "emit", "class": "OC_Hook", "type": "::" }, { "function": "OC\\{closure}", "class": "OC\\Server", "type": "->", "args": ["*** sensitive parameters replaced ***"] }, { "file": "/var/www/cloud/lib/private/Hooks/EmitterTrait.php", "line": 106, "function": "call_user_func_array" }, { "file": "/var/www/cloud/lib/private/Hooks/PublicEmitter.php", "line": 40, "function": "emit", "class": "OC\\Hooks\\BasicEmitter", "type": "->" }, { "file": "/var/www/cloud/lib/private/User/Session.php", "line": 400, "function": "emit", "class": "OC\\Hooks\\PublicEmitter", "type": "->" }, { "file": "/var/www/cloud/lib/private/Authentication/Login/CompleteLoginCommand.php", "line": 44, "function": "completeLogin", "class": "OC\\User\\Session", "type": "->", "args": ["*** sensitive parameters replaced ***"] }, { "file": "/var/www/cloud/lib/private/Authentication/Login/ALoginCommand.php", "line": 40, "function": "process", "class": "OC\\Authentication\\Login\\CompleteLoginCommand", "type": "->" }, { "file": "/var/www/cloud/lib/private/Authentication/Login/LoggedInCheckCommand.php", "line": 60, "function": "processNextOrFinishSuccessfully", "class": "OC\\Authentication\\Login\\ALoginCommand", "type": "->" }, { "file": "/var/www/cloud/lib/private/Authentication/Login/ALoginCommand.php", "line": 40, "function": "process", "class": "OC\\Authentication\\Login\\LoggedInCheckCommand", "type": "->" }, { "file": "/var/www/cloud/lib/private/Authentication/Login/EmailLoginCommand.php", "line": 58, "function": "processNextOrFinishSuccessfully", "class": "OC\\Authentication\\Login\\ALoginCommand", "type": "->" }, { "file": "/var/www/cloud/lib/private/Authentication/Login/ALoginCommand.php", "line": 40, "function": "process", "class": "OC\\Authentication\\Login\\EmailLoginCommand", "type": "->" }, { "file": "/var/www/cloud/lib/private/Authentication/Login/UidLoginCommand.php", "line": 54, "function": "processNextOrFinishSuccessfully", "class": "OC\\Authentication\\Login\\ALoginCommand", "type": "->" }, { "file": "/var/www/cloud/lib/private/Authentication/Login/ALoginCommand.php", "line": 40, "function": "process", "class": "OC\\Authentication\\Login\\UidLoginCommand", "type": "->" }, { "file": "/var/www/cloud/lib/private/Authentication/Login/UserDisabledCheckCommand.php", "line": 58, "function": "processNextOrFinishSuccessfully", "class": "OC\\Authentication\\Login\\ALoginCommand", "type": "->" }, { "file": "/var/www/cloud/lib/private/Authentication/Login/ALoginCommand.php", "line": 40, "function": "process", "class": "OC\\Authentication\\Login\\UserDisabledCheckCommand", "type": "->" }, { "file": "/var/www/cloud/lib/private/Authentication/Login/PreLoginHookCommand.php", "line": 53, "function": "processNextOrFinishSuccessfully", "class": "OC\\Authentication\\Login\\ALoginCommand", "type": "->" }, { "file": "/var/www/cloud/lib/private/Authentication/Login/Chain.php", "line": 108, "function": "process", "class": "OC\\Authentication\\Login\\PreLoginHookCommand", "type": "->" }, { "file": "/var/www/cloud/core/Controller/LoginController.php", "line": 329, "function": "process", "class": "OC\\Authentication\\Login\\Chain", "type": "->" }, { "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php", "line": 225, "function": "tryLogin", "class": "OC\\Core\\Controller\\LoginController", "type": "->", "args": ["*** sensitive parameters replaced ***"] }, { "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php", "line": 133, "function": "executeController", "class": "OC\\AppFramework\\Http\\Dispatcher", "type": "->" }, { "file": "/var/www/cloud/lib/private/AppFramework/App.php", "line": 172, "function": "dispatch", "class": "OC\\AppFramework\\Http\\Dispatcher", "type": "->" }, { "file": "/var/www/cloud/lib/private/Route/Router.php", "line": 298, "function": "main", "class": "OC\\AppFramework\\App", "type": "::" }, { "file": "/var/www/cloud/lib/base.php", "line": 1023, "function": "match", "class": "OC\\Route\\Router", "type": "->" }, { "file": "/var/www/cloud/index.php", "line": 36, "function": "handleRequest", "class": "OC", "type": "::" }], "File": "/var/www/cloud/lib/private/Log/ErrorHandler.php", "Line": 92, "CustomMessage": "--" } } { "reqId": "5HiSSTs2OKKG7whPwWY8", "level": 3, "time": "2022-08-19T15:47:15+00:00", "remoteAddr": "****::11", "user": "****-****-****-****", "app": "index", "method": "POST", "url": "/index.php/login", "message": "array_key_exists(): Argument #2 ($array) must be of type array, null given in file '/var/www/cloud/apps/user_ldap/lib/User/User.php' line 672", "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:103.0) Gecko/20100101 Firefox/103.0", "version": "24.0.4.1", "exception": { "Exception": "Exception", "Message": "array_key_exists(): Argument #2 ($array) must be of type array, null given in file '/var/www/cloud/apps/user_ldap/lib/User/User.php' line 672", "Code": 0, "Trace": [{ "file": "/var/www/cloud/lib/private/AppFramework/App.php", "line": 172, "function": "dispatch", "class": "OC\\AppFramework\\Http\\Dispatcher", "type": "->" }, { "file": "/var/www/cloud/lib/private/Route/Router.php", "line": 298, "function": "main", "class": "OC\\AppFramework\\App", "type": "::" }, { "file": "/var/www/cloud/lib/base.php", "line": 1023, "function": "match", "class": "OC\\Route\\Router", "type": "->" }, { "file": "/var/www/cloud/index.php", "line": 36, "function": "handleRequest", "class": "OC", "type": "::" }], "File": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php", "Line": 165, "Previous": { "Exception": "TypeError", "Message": "array_key_exists(): Argument #2 ($array) must be of type array, null given", "Code": 0, "Trace": [{ "file": "/var/www/cloud/apps/user_ldap/lib/User/User.php", "line": 672, "function": "array_key_exists" }, { "file": "/var/www/cloud/lib/private/legacy/OC_Hook.php", "line": 106, "function": "handlePasswordExpiry", "class": "OCA\\User_LDAP\\User\\User", "type": "->" }, { "file": "/var/www/cloud/lib/private/Server.php", "line": 609, "function": "emit", "class": "OC_Hook", "type": "::" }, { "function": "OC\\{closure}", "class": "OC\\Server", "type": "->", "args": ["*** sensitive parameters replaced ***"] }, { "file": "/var/www/cloud/lib/private/Hooks/EmitterTrait.php", "line": 106, "function": "call_user_func_array" }, { "file": "/var/www/cloud/lib/private/Hooks/PublicEmitter.php", "line": 40, "function": "emit", "class": "OC\\Hooks\\BasicEmitter", "type": "->" }, { "file": "/var/www/cloud/lib/private/User/Session.php", "line": 400, "function": "emit", "class": "OC\\Hooks\\PublicEmitter", "type": "->" }, { "file": "/var/www/cloud/lib/private/Authentication/Login/CompleteLoginCommand.php", "line": 44, "function": "completeLogin", "class": "OC\\User\\Session", "type": "->", "args": ["*** sensitive parameters replaced ***"] }, { "file": "/var/www/cloud/lib/private/Authentication/Login/ALoginCommand.php", "line": 40, "function": "process", "class": "OC\\Authentication\\Login\\CompleteLoginCommand", "type": "->" }, { "file": "/var/www/cloud/lib/private/Authentication/Login/LoggedInCheckCommand.php", "line": 60, "function": "processNextOrFinishSuccessfully", "class": "OC\\Authentication\\Login\\ALoginCommand", "type": "->" }, { "file": "/var/www/cloud/lib/private/Authentication/Login/ALoginCommand.php", "line": 40, "function": "process", "class": "OC\\Authentication\\Login\\LoggedInCheckCommand", "type": "->" }, { "file": "/var/www/cloud/lib/private/Authentication/Login/EmailLoginCommand.php", "line": 58, "function": "processNextOrFinishSuccessfully", "class": "OC\\Authentication\\Login\\ALoginCommand", "type": "->" }, { "file": "/var/www/cloud/lib/private/Authentication/Login/ALoginCommand.php", "line": 40, "function": "process", "class": "OC\\Authentication\\Login\\EmailLoginCommand", "type": "->" }, { "file": "/var/www/cloud/lib/private/Authentication/Login/UidLoginCommand.php", "line": 54, "function": "processNextOrFinishSuccessfully", "class": "OC\\Authentication\\Login\\ALoginCommand", "type": "->" }, { "file": "/var/www/cloud/lib/private/Authentication/Login/ALoginCommand.php", "line": 40, "function": "process", "class": "OC\\Authentication\\Login\\UidLoginCommand", "type": "->" }, { "file": "/var/www/cloud/lib/private/Authentication/Login/UserDisabledCheckCommand.php", "line": 58, "function": "processNextOrFinishSuccessfully", "class": "OC\\Authentication\\Login\\ALoginCommand", "type": "->" }, { "file": "/var/www/cloud/lib/private/Authentication/Login/ALoginCommand.php", "line": 40, "function": "process", "class": "OC\\Authentication\\Login\\UserDisabledCheckCommand", "type": "->" }, { "file": "/var/www/cloud/lib/private/Authentication/Login/PreLoginHookCommand.php", "line": 53, "function": "processNextOrFinishSuccessfully", "class": "OC\\Authentication\\Login\\ALoginCommand", "type": "->" }, { "file": "/var/www/cloud/lib/private/Authentication/Login/Chain.php", "line": 108, "function": "process", "class": "OC\\Authentication\\Login\\PreLoginHookCommand", "type": "->" }, { "file": "/var/www/cloud/core/Controller/LoginController.php", "line": 329, "function": "process", "class": "OC\\Authentication\\Login\\Chain", "type": "->" }, { "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php", "line": 225, "function": "tryLogin", "class": "OC\\Core\\Controller\\LoginController", "type": "->", "args": ["*** sensitive parameters replaced ***"] }, { "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php", "line": 133, "function": "executeController", "class": "OC\\AppFramework\\Http\\Dispatcher", "type": "->" }, { "file": "/var/www/cloud/lib/private/AppFramework/App.php", "line": 172, "function": "dispatch", "class": "OC\\AppFramework\\Http\\Dispatcher", "type": "->" }, { "file": "/var/www/cloud/lib/private/Route/Router.php", "line": 298, "function": "main", "class": "OC\\AppFramework\\App", "type": "::" }, { "file": "/var/www/cloud/lib/base.php", "line": 1023, "function": "match", "class": "OC\\Route\\Router", "type": "->" }, { "file": "/var/www/cloud/index.php", "line": 36, "function": "handleRequest", "class": "OC", "type": "::" }], "File": "/var/www/cloud/apps/user_ldap/lib/User/User.php", "Line": 672 }, "CustomMessage": "--" } } { "reqId": "drmZOACEwahqrtlOHPCf", "level": 4, "time": "2022-08-19T15:40:09+00:00", "remoteAddr": "****::11", "user": "****-****-****-****", "app": "webdav", "method": "PROPFIND", "url": "/remote.php/dav/files/****-****-****-****/", "message": "array_key_exists(): Argument #2 ($array) must be of type array, null given", "userAgent": "Mozilla/5.0 (Windows) mirall/3.4.2stable-Win64 (build 20220127) (Nextcloud, windows-10.0.19044 ClientArchitecture: x86_64 OsArchitecture: x86_64)", "version": "24.0.4.1", "exception": { "Exception": "TypeError", "Message": "array_key_exists(): Argument #2 ($array) must be of type array, null given", "Code": 0, "Trace": [{ "file": "/var/www/cloud/apps/user_ldap/lib/User/User.php", "line": 672, "function": "array_key_exists" }, { "file": "/var/www/cloud/lib/private/legacy/OC_Hook.php", "line": 106, "function": "handlePasswordExpiry", "class": "OCA\\User_LDAP\\User\\User", "type": "->" }, { "file": "/var/www/cloud/lib/private/Server.php", "line": 609, "function": "emit", "class": "OC_Hook", "type": "::" }, { "function": "OC\\{closure}", "class": "OC\\Server", "type": "->", "args": ["*** sensitive parameters replaced ***"] }, { "file": "/var/www/cloud/lib/private/Hooks/EmitterTrait.php", "line": 106, "function": "call_user_func_array" }, { "file": "/var/www/cloud/lib/private/Hooks/PublicEmitter.php", "line": 40, "function": "emit", "class": "OC\\Hooks\\BasicEmitter", "type": "->" }, { "file": "/var/www/cloud/lib/private/User/Session.php", "line": 400, "function": "emit", "class": "OC\\Hooks\\PublicEmitter", "type": "->" }, { "file": "/var/www/cloud/lib/private/User/Session.php", "line": 654, "function": "completeLogin", "class": "OC\\User\\Session", "type": "->", "args": ["*** sensitive parameters replaced ***"] }, { "file": "/var/www/cloud/lib/private/User/Session.php", "line": 353, "function": "loginWithToken", "class": "OC\\User\\Session", "type": "->", "args": ["*** sensitive parameters replaced ***"] }, { "file": "/var/www/cloud/lib/private/User/Session.php", "line": 450, "function": "login", "class": "OC\\User\\Session", "type": "->", "args": ["*** sensitive parameters replaced ***"] }, { "file": "/var/www/cloud/apps/dav/lib/Connector/Sabre/Auth.php", "line": 129, "function": "logClientIn", "class": "OC\\User\\Session", "type": "->", "args": ["*** sensitive parameters replaced ***"] }, { "file": "/var/www/cloud/3rdparty/sabre/dav/lib/DAV/Auth/Backend/AbstractBasic.php", "line": 103, "function": "validateUserPass", "class": "OCA\\DAV\\Connector\\Sabre\\Auth", "type": "->", "args": ["*** sensitive parameters replaced ***"] }, { "file": "/var/www/cloud/apps/dav/lib/Connector/Sabre/Auth.php", "line": 251, "function": "check", "class": "Sabre\\DAV\\Auth\\Backend\\AbstractBasic", "type": "->" }, { "file": "/var/www/cloud/apps/dav/lib/Connector/Sabre/Auth.php", "line": 154, "function": "auth", "class": "OCA\\DAV\\Connector\\Sabre\\Auth", "type": "->" }, { "file": "/var/www/cloud/3rdparty/sabre/dav/lib/DAV/Auth/Plugin.php", "line": 180, "function": "check", "class": "OCA\\DAV\\Connector\\Sabre\\Auth", "type": "->" }, { "file": "/var/www/cloud/3rdparty/sabre/dav/lib/DAV/Auth/Plugin.php", "line": 135, "function": "check", "class": "Sabre\\DAV\\Auth\\Plugin", "type": "->" }, { "file": "/var/www/cloud/3rdparty/sabre/event/lib/WildcardEmitterTrait.php", "line": 89, "function": "beforeMethod", "class": "Sabre\\DAV\\Auth\\Plugin", "type": "->" }, { "file": "/var/www/cloud/3rdparty/sabre/dav/lib/DAV/Server.php", "line": 456, "function": "emit", "class": "Sabre\\DAV\\Server", "type": "->" }, { "file": "/var/www/cloud/3rdparty/sabre/dav/lib/DAV/Server.php", "line": 253, "function": "invokeMethod", "class": "Sabre\\DAV\\Server", "type": "->" }, { "file": "/var/www/cloud/3rdparty/sabre/dav/lib/DAV/Server.php", "line": 321, "function": "start", "class": "Sabre\\DAV\\Server", "type": "->" }, { "file": "/var/www/cloud/apps/dav/lib/Server.php", "line": 358, "function": "exec", "class": "Sabre\\DAV\\Server", "type": "->" }, { "file": "/var/www/cloud/apps/dav/appinfo/v2/remote.php", "line": 35, "function": "exec", "class": "OCA\\DAV\\Server", "type": "->" }, { "file": "/var/www/cloud/remote.php", "line": 166, "args": ["/var/www/cloud/apps/dav/appinfo/v2/remote.php"], "function": "require_once" }], "File": "/var/www/cloud/apps/user_ldap/lib/User/User.php", "Line": 672, "CustomMessage": "--" } } { "reqId": "9FxSJKzzOUbrq65IDsk8", "level": 3, "time": "2022-08-19T15:31:44+00:00", "remoteAddr": "****::11", "user": "****-****-****-****", "app": "index", "method": "POST", "url": "/index.php/apps/user_ldap/ajax/wizard.php", "message": "The arguments array must contain 2 items, 1 given", "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:103.0) Gecko/20100101 Firefox/103.0", "version": "24.0.4.1", "exception": { "Exception": "ValueError", "Message": "The arguments array must contain 2 items, 1 given", "Code": 0, "Trace": [{ "file": "/var/www/cloud/lib/private/L10N/L10NString.php", "line": 88, "function": "vsprintf" }, { "file": "/var/www/cloud/lib/private/L10N/L10N.php", "line": 127, "function": "__toString", "class": "OC\\L10N\\L10NString", "type": "->" }, { "file": "/var/www/cloud/lib/private/L10N/LazyL10N.php", "line": 56, "function": "n", "class": "OC\\L10N\\L10N", "type": "->" }, { "file": "/var/www/cloud/apps/user_ldap/lib/Wizard.php", "line": 159, "function": "n", "class": "OC\\L10N\\LazyL10N", "type": "->" }, { "file": "/var/www/cloud/apps/user_ldap/ajax/wizard.php", "line": 96, "function": "countGroups", "class": "OCA\\User_LDAP\\Wizard", "type": "->" }, { "file": "/var/www/cloud/lib/private/Route/Route.php", "line": 155, "args": ["/var/www/cloud/apps/user_ldap/ajax/wizard.php"], "function": "require_once" }, { "function": "OC\\Route\\{closure}", "class": "OC\\Route\\Route", "type": "->", "args": ["*** sensitive parameters replaced ***"] }, { "file": "/var/www/cloud/lib/private/Route/Router.php", "line": 306, "function": "call_user_func" }, { "file": "/var/www/cloud/lib/base.php", "line": 1023, "function": "match", "class": "OC\\Route\\Router", "type": "->" }, { "file": "/var/www/cloud/index.php", "line": 36, "function": "handleRequest", "class": "OC", "type": "::" }], "File": "/var/www/cloud/lib/private/L10N/L10NString.php", "Line": 88, "CustomMessage": "--" } }Additional info
No response
The text was updated successfully, but these errors were encountered: