[Bug]: Update 24.0.0 beta2 to beta3, RC3 to final #31891
Comments
RoundAboutWEB
added
0. Needs triage
|
Can confirm same issue, finally restore from backup and avoid beta webpack.modules.js - can be deleted safely dist before (in ver 23) was located in ./core/js can confirm that problem exist if upgrade from 23 to 24b1 |
|
thanks for the report you need to delete these two files before running updater.phar again this is a known issue that will be ironed out for RC1 |
|
RC3 to final still had this issue on my instance
|
ChristophWurst
changed the title
|
I've compared the files. the rc3 and final .tar.bz2 contains the latest updater.phar from git. On my personal instance (rc3) the updater.phar is different. This could mean that the updater was not replaced during the upgrade to RC3. |
This comment was marked as outdated.
This comment was marked as outdated.
|
@ChristophWurst did you double check your permissions on path/to/nc/updater[/updater.phar]? |
|
also, checked the updater.log? |
|
To avoid problems with migrations all the tables should be set to dynamic row format: Had to add this to get the migrations up and running, before the mariadb server just die and restarted during the updates |
|
Finally converted all the tables with the script from here: |
|
Can confirm same issue 24b1 to 24final |
Beta1 was having the issue, the updater of beta 3 has (or latest rc1, but should be beta3) the fix. |
|
@ChristophWurst nothing striking in the log file… do you have another idea, why the updater was not replaced on your sys? on three other instances, mixed web and cli installer, i did not see the issue and the updaters were replaced correctly. |
I just tried an update with this results: Current version is 24.0.0 beta 1. Update to Nextcloud 24.0.0 available. (channel: "beta") Steps that will be executed: Start update? [y/N] y Info: Pressing Ctrl-C will finish the currently running step and then stops the updater. [✘] Check for expected files failed Update failed. To resume or retry just execute the updater again.
|
The instance was on |
|
that's ok, there was no dist folder on 23. The check kicks in before exchanging the files. |
|
23.0.0.10 to 24 RC3 was smooth. Only the RC3 to 24 final had the issue. The dist folder must have been the one of RC3. |
|
did GH lose my older comment? Here again: @schmidtvolker on Beta 1 this is expected and known. Delete the dist folder and continue with the upgrade as workaround. |
We're running in circles. 24 RC3 shipped the correct updater with the dist folder expectancy.
You're updater.phar was not replaced, but why? |
|
I would tell you if I knew. I checked the same things. I have no explanation, sorry. I have backups of the directory. Is there anything important info I could find in a time travel? |
|
@blizzz thx :) it works 👍 |
Could you e.g. dockerize and reprodce it? |
|
I can confirm that issue for an update from 4.0.0 stable to 4.0.1 stable as well. I had never any beta versions installed. The dist directory is also missing in updater.phar. Permission were correctly set. |
|
I confirm that our installations are cursed. |
|
Same from 24.0.1 to 24.0.2 update. As a data point Workaround manual upgrade, which includes a new |
Another maybe more easy workaround would be to just replace the updater.phar file from a downloaded .tar of your Nextcloud version. Then you can update your Nextcloud instance with the new updater file. |
Sure it is easier, but I am not involved enough in the project to know, if there are any dependencies to the |
|
what are the permissions on the updater.phar for those affected? |
|
|
|
|
The web user does not have permissions to replace them. |
|
Yes, no clue where it came from, changed it to www-data and will keep an eye on it. |
|
Same from 24.0.2 to 24.03 update. |
|
My guess - problem exist if SELinux in enforcing mode |
24.0.3 to 24.04 update shows same issue, even with
SELinux is not installed I even added the |
Adding dist to the updater/index.php file solved the issue for me. |
Confirmed for 24.0.4 to 24.0.5, thanks! |
|
Same problem out of the blue when upgrading from 24.0.5 to 24.0.7
|
|
I upgraded from 23.0.12 to 24.0.8 without issues and now trying to upgrade to 25.0.2 shows this error, I also manually changed updater/index.php |
|
Same issue when upgrading from 24.0.7 to 24.0.9 with |
|
This must have been a packaging issue for some 24.0.x releases. I fixed it by downloading that release, and replacing |
|
Hi, please update to 25.0.7 or better 26.0.2 and report back if it fixes the issue. Thank you! My goal is to add a label like e.g. 26-feedback to this ticket of an up-to-date major Nextcloud version where the bug could be reproduced. However this is not going to work without your help. So thanks for all your effort! If you don't manage to reproduce the issue in time and the issue gets closed but you can reproduce the issue afterwards, feel free to create a new bug report with up-to-date information by following this link: https://github.com/nextcloud/server/issues/new?assignees=&labels=bug%2C0.+Needs+triage&template=BUG_REPORT.yml&title=%5BBug%5D%3A+ |
|
I just updated from 23.0.12 to 24.0.12. updater/index.php and updater/updater.phar were not updated and thus caused this error when subsequently attempting to update to 25.0.12. The checksums of the two files match the ones in https://github.com/nextcloud/updater/tree/v23.0.12 and have modification dates from Dec 17 2022 which is probably when I upgraded to 23.0.12. Fixed by manually overwriting the two files with the ones from nextcloud 24.0.12 similar to how rasos did it two comments above: #31891 (comment) After the upgrade to 25.0.12 I still have updater/index.php and updater/updater.phar matching 24.0.12. So I think the problem that updater files not being updated is still present in Nextcloud 25. If the issue remains after I get around to updating to Nextcloud 26 then I might make a new bug report. |
Bug description
[✘] Check for expected files failed
The following extra files have been found:
dist
webpack.modules.js
Update failed. To resume or retry just execute the updater again.
Steps to reproduce
Update from beta1 to beta2 was no problem
Expected behavior
I was expecting a successful update from 24.0.0 beta2 to 24.0.0. beta3.
Installation method
Manual installation
Operating system
Debian/Ubuntu
PHP engine version
PHP 8.0
Web server
Apache (supported)
Database engine version
MySQL
Is this bug present after an update or on a fresh install?
No response
Are you using the Nextcloud Server Encryption module?
Encryption is Enabled
What user-backends are you using?
Configuration report
{ "system": { "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "cloud.email2you.de" ], "datadirectory": "***REMOVED SENSITIVE VALUE***", "dbtype": "mysql", "version": "24.0.0.7", "overwrite.cli.url": "https:\/\/cloud.email2you.de\/", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbport": "", "dbtableprefix": "oc_", "mysql.utf8mb4": true, "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "installed": true, "instanceid": "***REMOVED SENSITIVE VALUE***", "htaccess.RewriteBase": "\/", "default_language": "de", "default_locale": "de_DE", "default_phone_region": "DE", "mail_smtpmode": "smtp", "mail_smtpsecure": "tls", "mail_smtpauthtype": "LOGIN", "mail_smtpauth": 1, "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpport": "25", "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_domain": "***REMOVED SENSITIVE VALUE***", "mail_smtpname": "***REMOVED SENSITIVE VALUE***", "mail_smtppassword": "***REMOVED SENSITIVE VALUE***", "check_for_working_wellknown_setup": false, "skeletondirectory": "\/files\/nextcloud\/data\/eigenes-skeleton", "theme": "", "loglevel": 0, "maintenance": false, "memcache.local": "", "updater.release.channel": "beta", "updater.secret": "***REMOVED SENSITIVE VALUE***" } }List of activated Apps
Nextcloud Signing status
Nextcloud Logs
{"reqId":"fFReINqBEr82jMCsGSv7","level":2,"time":"2022-02-08T19:27:57+00:00","remoteAddr":"87.155.22.20","user":"p609512","app":"ocs_api","method":"POST","url":"/ocs/v2.php/cloud /users","message":"Failed addUser attempt with hint exception.","userAgent":"Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:96.0) Gecko/20100101 Firefox/96.0","version":"23.0.1.2","e xception":{"Exception":"OC\\HintException","Message":"Password is present in compromised password list. Please choose a different password.","Code":0,"Trace":[{"file":"/html/next cloud/apps/password_policy/lib/Listener/ValidatePasswordPolicyEventListener.php","line":46,"function":"validate","class":"OCA\\Password_Policy\\PasswordValidator","type":"->","ar gs":["*** sensitive parameter replaced ***"]},{"file":"/html/nextcloud/lib/private/EventDispatcher/ServiceEventListener.php","line":87,"function":"handle","class":"OCA\\Password_ Policy\\Listener\\ValidatePasswordPolicyEventListener","type":"->","args":[{"__class__":"OCP\\Security\\Events\\ValidatePasswordPolicyEvent"}]},{"file":"/html/nextcloud/3rdparty/ symfony/event-dispatcher/EventDispatcher.php","line":251,"function":"__invoke","class":"OC\\EventDispatcher\\ServiceEventListener","type":"->","args":[{"__class__":"OCP\\Security \\Events\\ValidatePasswordPolicyEvent"},"OCP\\Security\\Events\\ValidatePasswordPolicyEvent",{"__class__":"Symfony\\Component\\EventDispatcher\\EventDispatcher"}]},{"file":"/html /nextcloud/3rdparty/symfony/event-dispatcher/EventDispatcher.php","line":73,"function":"callListeners","class":"Symfony\\Component\\EventDispatcher\\EventDispatcher","type":"->", "args":[[{"__class__":"Closure"}],"OCP\\Security\\Events\\ValidatePasswordPolicyEvent",{"__class__":"OCP\\Security\\Events\\ValidatePasswordPolicyEvent"}]},{"file":"/html/nextclo ud/lib/private/EventDispatcher/EventDispatcher.php","line":88,"function":"dispatch","class":"Symfony\\Component\\EventDispatcher\\EventDispatcher","type":"->","args":[{"__class__ ":"OCP\\Security\\Events\\ValidatePasswordPolicyEvent"},"OCP\\Security\\Events\\ValidatePasswordPolicyEvent"]},{"file":"/html/nextcloud/lib/private/EventDispatcher/EventDispatche r.php","line":100,"function":"dispatch","class":"OC\\EventDispatcher\\EventDispatcher","type":"->","args":["OCP\\Security\\Events\\ValidatePasswordPolicyEvent",{"__class__":"OCP\ \Security\\Events\\ValidatePasswordPolicyEvent"}]},{"file":"/html/nextcloud/lib/private/User/Database.php","line":123,"function":"dispatchTyped","class":"OC\\EventDispatcher\\Eve ntDispatcher","type":"->","args":[{"__class__":"OCP\\Security\\Events\\ValidatePasswordPolicyEvent"}]},{"file":"/html/nextcloud/lib/private/User/Manager.php","line":463,"function ":"createUser","class":"OC\\User\\Database","type":"->","args":["*** sensitive parameter replaced ***","*** sensitive parameter replaced ***"]},{"file":"/html/nextcloud/lib/priva te/User/Manager.php","line":407,"function":"createUserFromBackend","class":"OC\\User\\Manager","type":"->","args":["*** sensitive parameter replaced ***","*** sensitive parameter replaced ***",{"__class__":"OC\\User\\Database"}]},{"file":"/html/nextcloud/apps/provisioning_api/lib/Controller/UsersController.php","line":417,"function":"createUser","class": "OC\\User\\Manager","type":"->","args":["*** sensitive parameter replaced ***","*** sensitive parameter replaced ***"]},{"file":"/html/nextcloud/lib/private/AppFramework/Http/Dis patcher.php","line":217,"function":"addUser","class":"OCA\\Provisioning_API\\Controller\\UsersController","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/ html/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":126,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class_ _":"OCA\\Provisioning_API\\Controller\\UsersController"},"addUser"]},{"file":"/html/nextcloud/lib/private/AppFramework/App.php","line":157,"function":"dispatch","class":"OC\\AppF ramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Provisioning_API\\Controller\\UsersController"},"addUser"]},{"file":"/html/nextcloud/lib/private/Route/Router.p hp","line":302,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Provisioning_API\\Controller\\UsersController","addUser",{"__class__":"OC\\AppFramework \\DependencyInjection\\DIContainer"},{"_route":"ocs.provisioning_api.Users.addUser"}]},{"file":"/html/nextcloud/ocs/v1.php","line":62,"function":"match","class":"OC\\Route\\Route r","type":"->","args":["/ocsapp/cloud/users"]},{"file":"/html/nextcloud/ocs/v2.php","line":23,"args":["/html/nextcloud/ocs/v1.php"],"function":"require_once"}],"File":"/html/next cloud/apps/password_policy/lib/PasswordValidator.php","Line":87,"Hint":"Das Passwort ist in der Liste der kompromittierten Passw\u00f6rter enthalten. Bitte w\u00e4hle ein anderes Passwort.","CustomMessage":"Failed addUser attempt with hint exception."}}Additional info
No response
The text was updated successfully, but these errors were encountered: