Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show modules required for webauthn in setupcheck #20393

Closed
rullzer opened this issue Apr 9, 2020 · 1 comment · Fixed by #20421
Closed

Show modules required for webauthn in setupcheck #20393

rullzer opened this issue Apr 9, 2020 · 1 comment · Fixed by #20421
Assignees
Labels
1. to develop Accepted and waiting to be taken care of enhancement
Milestone

Comments

@rullzer
Copy link
Member

rullzer commented Apr 9, 2020

So people can actually discover it.

@rullzer rullzer added enhancement 1. to develop Accepted and waiting to be taken care of labels Apr 9, 2020
@rullzer rullzer added this to the Nextcloud 19 milestone Apr 9, 2020
@rullzer rullzer self-assigned this Apr 9, 2020
rullzer added a commit that referenced this issue Apr 10, 2020
Fixes #20393

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@MichaIng
Copy link
Member

MichaIng commented May 8, 2020

@rullzer
Just found this and must say I don't like to see two additional general PHP module recommendations for "performance and stability" reasons, which are only required for a specific feature. While searching for the reason for this two modules, I found a blog post about NC19 beta update experience, presenting very well that most users, also bloggers, simply pull everything that shows up as recommendations without a thought about what it is actually for. It is nothing serious but I would like to have this only checked and shown when someone actually attempts to setup webauthn.

So probably it could be switched:

  • Always show webauthn option on security page.
  • Do a check for required PHP modules as fast as user attempts to setup webauthn and prompt a warning if those are missing.

This would also better match the docs, which list those "for specific apps" instead of as "recommended packages": https://docs.nextcloud.com/server/latest/admin_manual/installation/source_installation.html

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants