Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of regions #14822

Open
Valdnet opened this issue Mar 24, 2019 · 17 comments
Open

Translation of regions #14822

Valdnet opened this issue Mar 24, 2019 · 17 comments
Labels

Comments

@Valdnet
Copy link
Contributor

Valdnet commented Mar 24, 2019

In Transifex there are no names of regions to be translated for the Nextcloud settings.

obraz

It can do as with the choice of language, for example.: __region_name__.

@Valdnet Valdnet added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Mar 24, 2019
@MorrisJobke
Copy link
Member

Makes sense 👍

@MorrisJobke MorrisJobke added the papercut Annoying recurring issue with possibly simple fix. label Mar 25, 2019
@MorrisJobke MorrisJobke self-assigned this Mar 25, 2019
@MorrisJobke MorrisJobke added this to the Nextcloud 16 milestone Mar 25, 2019
@MorrisJobke
Copy link
Member

This is all defined in the file resources/locales.json:

https://github.com/nextcloud/server/blob/8c73b13ac870b0a6b75b701f4f52463c198421a5/resources/locales.json

@nickvergessen @rullzer @ChristophWurst: Do you have a clever way to translate this?

@MorrisJobke
Copy link
Member

I would just add a new attribute localizedName and then put in there the name in the related language.

@MorrisJobke
Copy link
Member

But even better would be if it would be depending on the currently selected language. Maybe I can somehow extract the name there and then put it into the lib translation files.

@Valdnet
Copy link
Contributor Author

Valdnet commented Mar 25, 2019

@MorrisJobke why is it twice Polish? The Polish language has no dialects.

{ "code":"pl_PL", "name":"Polish (Poland)"},
{ "code":"pl", "name":"Polish"},

@MorrisJobke
Copy link
Member

It's how locale works I guess. There are just per language and then per language and per country. I would keep that for now and open a separate ticket for this duplicate entry.

@MorrisJobke MorrisJobke removed their assignment Mar 26, 2019
@Valdnet
Copy link
Contributor Author

Valdnet commented Feb 6, 2021

@MorrisJobke In NC version 20.0.6 there are still no translated region.

obraz

@Valdnet Valdnet reopened this Feb 6, 2021
@szaimen
Copy link
Contributor

szaimen commented Jun 23, 2021

Seems like this is still valid on NC21.0.2

@szaimen szaimen added 1. to develop Accepted and waiting to be taken care of feature: language l10n and translations and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap papercut Annoying recurring issue with possibly simple fix. labels Jun 23, 2021
@szaimen szaimen removed this from the Nextcloud 16 milestone Jun 23, 2021
@Valdnet
Copy link
Contributor Author

Valdnet commented Aug 28, 2021

@MorrisJobke @nickvergessen Until now, there are no translated regions in Nextcloud 22.1.1. I looked at the translations in Transifex and there are also no text strings to translate about the names of the regions in this file "locales.json".

@Valdnet
Copy link
Contributor Author

Valdnet commented Aug 29, 2021

Translated text strings of region names from the file "locales.json" should be in the l10n directory for "settings".

Here are the translated names of the regions:

obraz

@MorrisJobke @rakekniven How do I get region name text strings in Transifex for "settings-1"?

He can put the locales.php file in the settings/lib/locales directory with the contents of the text strings with the region names to be scanned by nextcloud-bot and added to Transifex.

An example of the locales.php file:

<?php
p($l->t('Afrikaans'));
p($l->t('Afrikaans (Namibia)'));
p($l->t('Afrikaans (South Africa)'));
p($l->t('Aghem'));
//...
?>

@nickvergessen
Copy link
Member

Morris is not here anymore.

The problem is it might overload translators a lot if they have to do it to finish the settings.
Maybe instead we can put it into a new l10n dir "regions" or something a like

@Salvador1313
Copy link

Salvador1313 commented Aug 30, 2021 via email

@Valdnet
Copy link
Contributor Author

Valdnet commented Aug 30, 2021

Morris is not here anymore.

I did not know 😮.
Who has taken over his duties now?

Maybe instead we can put it into a new l10n dir "regions" or something a like

A very good thought 😉.

@Valdnet
Copy link
Contributor Author

Valdnet commented Aug 30, 2021

I can prepare region name text strings in a php file because it takes some time and developers have other more important things to do. I just need help changing the code in the personal.info.php file to reference the new l10n location.

@nickvergessen
Copy link
Member

Isn't this ticket about regions and not locales?

@Valdnet
Copy link
Contributor Author

Valdnet commented Aug 30, 2021

Isn't this ticket about regions and not locales?

Hmmm. It concerns supposedly regions. This is what the setting option is called, but the settings are more suited to the localization settings.

In general, text strings are taken from the locales.json. However, in commit #14853 the code has been changed, where names should be changed to a given language. Only the translated text strings in l10n are missing.

@Valdnet
Copy link
Contributor Author

Valdnet commented Nov 6, 2021

The Issue somehow stood still.
I can still do the translation, I just need help changing the code in the personal.info.php file to reference the new l10n location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants