-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2FA settings icons don’t invert in dark theme #13643
Labels
1. to develop
Accepted and waiting to be taken care of
bug
design
Design, UI, UX, etc.
feature: settings
good first issue
Small tasks with clear documentation about how and in which place you need to fix things in.
Comments
jancborchardt
added
bug
1. to develop
Accepted and waiting to be taken care of
feature: settings
labels
Jan 17, 2019
jancborchardt
added
good first issue
Small tasks with clear documentation about how and in which place you need to fix things in.
design
Design, UI, UX, etc.
labels
Jan 28, 2019
Code in question server/settings/templates/settings/personal/security.php Lines 76 to 82 in 1f47c69
|
GretaD
added a commit
that referenced
this issue
May 17, 2019
Signed-off-by: Greta Doci <gretadoci@gmail.com>
GretaD
added a commit
that referenced
this issue
May 21, 2019
Signed-off-by: Greta Doci <gretadoci@gmail.com>
GretaD
added a commit
that referenced
this issue
May 22, 2019
Signed-off-by: Greta Doci <gretadoci@gmail.com>
skjnldsv
added a commit
that referenced
this issue
May 29, 2019
nachoparker
pushed a commit
to nachoparker/server
that referenced
this issue
Jun 28, 2019
Signed-off-by: Greta Doci <gretadoci@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1. to develop
Accepted and waiting to be taken care of
bug
design
Design, UI, UX, etc.
feature: settings
good first issue
Small tasks with clear documentation about how and in which place you need to fix things in.
With the dark theme, 2FA settings look like this:
That’s because they are loaded in the
<img>
tag. Ideally it should be changed to use a class on the header likeicon-…
so it’s used as background-image.Documentation on that at: https://docs.nextcloud.com/server/latest/developer_manual/design/css.html#scss-icons-mixins
The text was updated successfully, but these errors were encountered: