-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup middleware registering #12224
Labels
Milestone
Comments
rullzer
added
1. to develop
Accepted and waiting to be taken care of
technical debt
labels
Nov 2, 2018
rullzer
added a commit
that referenced
this issue
Nov 23, 2018
Fixes #12224 Since we only use the middleware at 1 location it makes no sense to register them in each and every container. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
added a commit
that referenced
this issue
Dec 10, 2018
Fixes #12224 Since we only use the middleware at 1 location it makes no sense to register them in each and every container. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
added a commit
that referenced
this issue
Dec 27, 2018
Fixes #12224 Since we only use the middleware at 1 location it makes no sense to register them in each and every container. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
added a commit
that referenced
this issue
Jan 3, 2019
Fixes #12224 Since we only use the middleware at 1 location it makes no sense to register them in each and every container. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
added a commit
that referenced
this issue
Jan 3, 2019
Fixes #12224 Since we only use the middleware at 1 location it makes no sense to register them in each and every container. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We register the middleware services in each and every DIContainer.
This is not really needed as the only place we query them is in:
server/lib/private/AppFramework/DependencyInjection/DIContainer.php
Lines 313 to 335 in 9319d55
We can just properly query or register them there.
The text was updated successfully, but these errors were encountered: