Recent Files sometimes don't work

[karlitschek]

If you click on recent files in the left side bar you should see your recent changed files. This works on my private instance but on cloud.nc.com I only see an empty page.

[nextcloud-bot]

GitMate.io thinks possibly related issues are #4644 (Jumping to file directly is not working), #5876 ("Allow editing" on a file doesn't work), #7398 (Horizontal scaling - file locking not working?), #3488 (File Upload works but can't upload folder), and #6429 (Locked file).

[MorrisJobke]

cc @rullzer @nickvergessen @skjnldsv

[koarlmichael]

Here the same with Nextcloud 14.0.2. I only see an empty page on recent files.

[MorrisJobke]

Same here:

This request:

/apps/files/api/v1/recent

Just returns nothing:

{"files":[]}

This is how it should look like:

{"files":[{"id":"135","parentId":"2","mtime":1539855850000,"name":"Bildschirmfoto...

Or it should have a decent empty screen:

[violoncelloCH]

Are there groupfolders active for the users/instances it doesn't work?
I also encountered this one a while ago, but for me it only happens for users which have access to a groupfolder. See nextcloud/groupfolders#124

[MorrisJobke]

Are there groupfolders active for the users/instances it doesn't work?

On the instance of @karlitschek it isn't.

[karlitschek]

yep. no groupfolders here

[Schmuuu]

Hi,
I just stumbled across this issue and can confirm it happens on NC15 still. However, I noticed something strange and wonder if the root cause of this issue might be a wrong time range for "recent":

... the future.
Of course, I don't know why this file will be edited on May 12th in 2034 at 12:15 first, but it seems to be listed due to this fact ;)

[MorrisJobke]

We just looked into this and the reason for this behavior is that shared folders are not fetched for the "recent files" view:

server/lib/private/Files/Node/Folder.php

Lines 364 to 414 in 9d9f690

	public function getRecent($limit, $offset = 0) {
	$mimetypeLoader = \OC::$server->getMimeTypeLoader();
	$mounts = $this->root->getMountsIn($this->path);
	$mounts[] = $this->getMountPoint();
	$mounts = array_filter($mounts, function (IMountPoint $mount) {
	return $mount->getStorage();
	});
	$storageIds = array_map(function (IMountPoint $mount) {
	return $mount->getStorage()->getCache()->getNumericStorageId();
	}, $mounts);
	/** @var IMountPoint[] $mountMap */
	$mountMap = array_combine($storageIds, $mounts);
	$folderMimetype = $mimetypeLoader->getId(FileInfo::MIMETYPE_FOLDER);
	//todo look into options of filtering path based on storage id (only search in files/ for home storage, filter by share root for shared, etc)
	$builder = \OC::$server->getDatabaseConnection()->getQueryBuilder();
	$query = $builder
	->select('f.*')
	->from('filecache', 'f')
	->andWhere($builder->expr()->in('f.storage', $builder->createNamedParameter($storageIds, IQueryBuilder::PARAM_INT_ARRAY)))
	->andWhere($builder->expr()->orX(
	// handle non empty folders separate
	$builder->expr()->neq('f.mimetype', $builder->createNamedParameter($folderMimetype, IQueryBuilder::PARAM_INT)),
	$builder->expr()->eq('f.size', new Literal(0))
	))
	->orderBy('f.mtime', 'DESC')
	->setMaxResults($limit)
	->setFirstResult($offset);
	$result = $query->execute()->fetchAll();
	$files = array_filter(array_map(function (array $entry) use ($mountMap, $mimetypeLoader) {
	$mount = $mountMap[$entry['storage']];
	$entry['internalPath'] = $entry['path'];
	$entry['mimetype'] = $mimetypeLoader->getMimetypeById($entry['mimetype']);
	$entry['mimepart'] = $mimetypeLoader->getMimetypeById($entry['mimepart']);
	$path = $this->getAbsolutePath($mount, $entry['path']);
	if (is_null($path)) {
	return null;
	}
	$fileInfo = new \OC\Files\FileInfo($path, $mount->getStorage(), $entry['internalPath'], $entry, $mount);
	return $this->root->createNode($fileInfo->getPath(), $fileInfo);
	}, $result));
	return array_values(array_filter($files, function (Node $node) {
	$relative = $this->getRelativePath($node->getPath());
	return $relative !== null && $relative !== '/';
	}));
	}

It only fetches from real storages with a storage ID that stored in the file cache, but shares are only virtual mount points into the user folder and thus it will not fetch the recent files from them properly.

cc @icewind1991 @rullzer Any clever idea how to also include those subfolders or single files of storages in the SQL query or should we inject them separately somehow?

[rullzer]

So. it seems we have code duplication here I think. because we could just use the cache searching. There shared folders work. (it is the thing we use for the dav searches as well). It is not the most effective code but good enough for now I'd say.

[rnwgnr]

I have a similar issue with "recent" files, the file list is completely empty although i have numerous files uploaded/updated today.

Running NextCloud 15.0.2 with PHP 7.2 and local storage only.

[MorrisJobke]

Fix is in #14185