Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to custom prepare of search term for LDAP #10136

Open
fgsl opened this issue Jul 6, 2018 · 3 comments
Open

Allow to custom prepare of search term for LDAP #10136

fgsl opened this issue Jul 6, 2018 · 3 comments
Assignees
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: ldap

Comments

@fgsl
Copy link

fgsl commented Jul 6, 2018

This change is related to issue #8760 and it seems to me a best way to meet general and specific interests.

Scenario:

A customer requires that search term in LDAP uses '*' . $term . '*'. Nextcloud in user_ldap/lib/Access.php uses $term . '*'. I agree that demand of only one is not enough to change a general behavior. But I think that must be possible to change behavior according to requirements.

At same time, that customer requires authentication with security token. We are using a customized version of user_saml (general changes were submitted here). For a better login performance, we have to restore search term to current Nextcloud implementation.

Then, I thought that issue #8760 can be closed if it is possible to replace search term expression on demand. It can be made though a customization app like Initialcheck. So, each sysadmin can configure LDAP search behaviour according his requirements without to change standard way of Nextcloud.

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #9898 (Appstore: allow search across all categories), #3854 ("Resharing is not allowed" for LDAP users), #7175 (Allow to search for email address in user management), #6799 (search/results.css not overriding from custom theme), and #7180 (Search field).

@skjnldsv skjnldsv added the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Aug 20, 2020
@szaimen
Copy link
Contributor

szaimen commented Jun 9, 2021

@nextcloud/ldap is this feasible?

@blizzz
Copy link
Member

blizzz commented Jun 9, 2021

there was already one community attempt (or two) to introduce this, but they did not go into a mergable state. Thus, I'll still consider a PR if it is provided.

@szaimen szaimen added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap needs info labels Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: ldap
Projects
None yet
Development

No branches or pull requests

6 participants