Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share dialog doesn't show more then two exact matches? #10114

Closed
schiessle opened this issue Jul 5, 2018 · 4 comments
Closed

share dialog doesn't show more then two exact matches? #10114

schiessle opened this issue Jul 5, 2018 · 4 comments
Assignees
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug feature: sharing

Comments

@schiessle
Copy link
Member

I just noticed that on master only two exact matches are shown in the share dialog.

If I test the guest app (nextcloud/guests#1) or federated group shares (#9895) always only two exact matches are shown. In case of the guest apps this means the guest email address and the same address with the option to send a federated share (remote) and in case of federated group sharing it shows the option to send a federated share (remote) or a federated group share (remote group) but the "share by mail option" is always missing although the API returns all three results correctly.

Therefore I assume that we limit the list of exact matches to two. Can some of our JS experts check this and remove this limit? Thanks!

@nextcloud/javascript

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #3918 (share dialog broken), #5485 (Sharing: Members are not shown), #6807 (Sharing dialog returns duplicate entries), #5639 (Remote share emails doesn't show what's shared.), and #2329 (drop down overlap in share dialog).

@weeman1337 weeman1337 self-assigned this Aug 15, 2018
@weeman1337
Copy link
Member

@schiessle at least for the guests app it isn't a JavaScript limit. The guests app handles the autocomplete different (https://github.com/nextcloud/guests/blob/make-compatible-with-nextcloud/js/app.js#L171). It doesn't recognize the email shares yet. I'll have a look at this and will update the guests app "make-compatible-with-nextcloud" branch.

weeman1337 added a commit to nextcloud/guests that referenced this issue Aug 15, 2018
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
@MorrisJobke MorrisJobke removed this from the Nextcloud 14 milestone Aug 24, 2018
@skjnldsv skjnldsv added the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Jun 12, 2019
@skjnldsv
Copy link
Member

skjnldsv commented Aug 7, 2019

What is the status of this issue? Still make sense?

@skjnldsv
Copy link
Member

We show a bit more now I think :)
Fixed with #15719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug feature: sharing
Projects
None yet
Development

No branches or pull requests

5 participants