Merge pull request #933 from nextcloud/backport-930-check-isset-requi…

…re-9 [stable9] Fix "Undefined index" when the values do not exist
nextcloud · Aug 18, 2016 · f5bbf82 · f5bbf82
2 parents 2d025db + f7092c9
commit f5bbf82
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/private/app/codechecker/infochecker.php b/lib/private/app/codechecker/infochecker.php
@@ -80,7 +80,7 @@ public function analyse($appId) {
 
 		$info = $this->infoParser->parse($appPath . '/appinfo/info.xml');
 
-		if (isset($info['dependencies']['owncloud']['@attributes']['min-version']) && ($info['requiremin'] || $info['require'])) {
+		if (isset($info['dependencies']['owncloud']['@attributes']['min-version']) && (isset($info['requiremin']) || isset($info['require']))) {
 			$this->emit('InfoChecker', 'duplicateRequirement', ['min']);
 			$errors[] = [
 				'type' => 'duplicateRequirement',
@@ -90,7 +90,7 @@ public function analyse($appId) {
 			$this->emit('InfoChecker', 'missingRequirement', ['min']);
 		}
 
-		if (isset($info['dependencies']['owncloud']['@attributes']['max-version']) && $info['requiremax']) {
+		if (isset($info['dependencies']['owncloud']['@attributes']['max-version']) && isset($info['requiremax'])) {
 			$this->emit('InfoChecker', 'duplicateRequirement', ['max']);
 			$errors[] = [
 				'type' => 'duplicateRequirement',