Skip to content

Commit

Permalink
Don't provide favorite activity settings
Browse files Browse the repository at this point in the history
Since mails and notifications are only available for actions of other users
it does not make sense to allow changing this.
It also prevents the common misunderstanding with
"file was changed inside a favorited folder"

Signed-off-by: Joas Schilling <coding@schilljs.com>
  • Loading branch information
nickvergessen authored and come-nc committed Feb 17, 2022
1 parent ef67f01 commit c090b3f
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions apps/files/lib/Activity/Settings/FavoriteAction.php
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public function getPriority() {
* @since 11.0.0
*/
public function canChangeStream() {
return true;
return false;
}

/**
Expand All @@ -71,7 +71,7 @@ public function isDefaultEnabledStream() {
* @since 11.0.0
*/
public function canChangeMail() {
return true;
return false;
}

/**
Expand All @@ -81,4 +81,12 @@ public function canChangeMail() {
public function isDefaultEnabledMail() {
return false;
}

/**
* @return bool True when the option can be changed for the notification
* @since 20.0.0
*/
public function canChangeNotification() {
return false;
}
}

0 comments on commit c090b3f

Please sign in to comment.