Skip to content

Commit

Permalink
Allow target="_blank" in app navigation items
Browse files Browse the repository at this point in the history
Which was removed in the Vue rewrite in #33728. This breaks things like nextcloud/external#79

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
  • Loading branch information
tcitworld authored and nextcloud-command committed Dec 8, 2022
1 parent 7730309 commit a54d82b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
4 changes: 3 additions & 1 deletion core/src/components/AppMenu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@
:class="{ 'has-unread': app.unread > 0 }"
:aria-label="appLabel(app)"
:title="app.name"
:aria-current="app.active ? 'page' : false">
:aria-current="app.active ? 'page' : false"
:target="app.target ? '_blank' : undefined"
:rel="app.target ? 'noopener noreferrer' : undefined">
<img :src="app.icon" alt="">
<div class="app-menu-entry--label">
{{ app.name }}
Expand Down
4 changes: 2 additions & 2 deletions dist/core-main.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-main.js.map

Large diffs are not rendered by default.

0 comments on commit a54d82b

Please sign in to comment.