Merge pull request #35113 from nextcloud/backport/35015/stable24

[stable24] Appropriate length check in Notification.php
nextcloud · Nov 13, 2022 · 80040cb · 80040cb
2 parents b4b206c + d4f9b82
commit 80040cb
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/private/Notification/Notification.php b/lib/private/Notification/Notification.php
@@ -197,12 +197,12 @@ public function getDateTime(): \DateTime {
 	 * @since 8.2.0 - 9.0.0: Type of $id changed to string
 	 */
 	public function setObject(string $type, string $id): INotification {
-		if ($type === '' || isset($type[64])) {
+		if ($type === '' || mb_strlen($type) > 64) {
 			throw new \InvalidArgumentException('The given object type is invalid');
 		}
 		$this->objectType = $type;
 
-		if ($id === '' || isset($id[64])) {
+		if ($id === '' || mb_strlen($id) > 64) {
 			throw new \InvalidArgumentException('The given object id is invalid');
 		}
 		$this->objectId = $id;