Prevent unnecesary profile action registrations

Signed-off-by: Christopher Ng <chrng8@gmail.com>
nextcloud · Oct 25, 2021 · 795a306 · 795a306
1 parent 9f8eae3
commit 795a306
Showing 1 changed file with 20 additions and 11 deletions.
diff --git a/lib/private/Profile/ProfileManager.php b/lib/private/Profile/ProfileManager.php
@@ -74,6 +74,9 @@ class ProfileManager {
 	/** @var ILinkAction[] */
 	private $actions = [];
 
+	/** @var null|ILinkAction[] */
+	private $sortedActions = null;
+
 	/**
 	 * Array of account property actions
 	 */
@@ -157,29 +160,35 @@ private function registerAction(IUser $targetUser, ?IUser $visitingUser, ILinkAc
 	 * @return ILinkAction[]
 	 */
 	private function getActions(IUser $targetUser, ?IUser $visitingUser): array {
-		$context = $this->coordinator->getRegistrationContext();
-		if ($context === null) {
-			return [];
+		// If actions are already registered and sorted, return them
+		if ($this->sortedActions !== null) {
+			return $this->sortedActions;
 		}
 
 		foreach (self::ACCOUNT_PROPERTY_ACTIONS as $actionClass) {
-			/** @var ILinkAction $provider */
-			$provider = $this->container->get($actionClass);
-			$this->registerAction($targetUser, $visitingUser, $provider);
+			/** @var ILinkAction $action */
+			$action = $this->container->get($actionClass);
+			$this->registerAction($targetUser, $visitingUser, $action);
 		}
 
-		foreach ($context->getProfileLinkActions() as $registration) {
-			/** @var ILinkAction $provider */
-			$provider = $this->container->get($registration->getService());
-			$this->registerAction($targetUser, $visitingUser, $provider);
+		$context = $this->coordinator->getRegistrationContext();
+
+		if ($context !== null) {
+			foreach ($context->getProfileLinkActions() as $registration) {
+				/** @var ILinkAction $action */
+				$action = $this->container->get($registration->getService());
+				$this->registerAction($targetUser, $visitingUser, $action);
+			}
 		}
 
 		$actionsClone = $this->actions;
 		// Sort associative array into indexed array in ascending order of priority
 		usort($actionsClone, function (ILinkAction $a, ILinkAction $b) {
 			return $a->getPriority() === $b->getPriority() ? 0 : ($a->getPriority() < $b->getPriority() ? -1 : 1);
 		});
-		return $actionsClone;
+
+		$this->sortedActions = $actionsClone;
+		return $this->sortedActions;
 	}
 
 	/**