Merge pull request #4430 from nextcloud/refactor-auth

Improve readability of login logic
nextcloud · Apr 26, 2017 · 5b5c3a1 · 5b5c3a1
2 parents bec9f18 + fff6d6e
commit 5b5c3a1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 14 deletions.
diff --git a/lib/private/legacy/api.php b/lib/private/legacy/api.php
@@ -332,25 +332,20 @@ private static function loginUser() {
 		$userSession = \OC::$server->getUserSession();
 		$request = \OC::$server->getRequest();
 		try {
-			$loginSuccess = $userSession->tryTokenLogin($request);
-			if (!$loginSuccess) {
-				$loginSuccess = $userSession->tryBasicAuthLogin($request, \OC::$server->getBruteForceThrottler());
+			if ($userSession->tryTokenLogin($request)
+				|| $userSession->tryBasicAuthLogin($request, \OC::$server->getBruteForceThrottler())) {
+				self::$logoutRequired = true;
+			} else {
+				return false;
 			}
-		} catch (\OC\User\LoginException $e) {
-			return false;
-		}
-
-		if ($loginSuccess === true) {
-			self::$logoutRequired = true;
-
 			// initialize the user's filesystem
 			\OC_Util::setupFS(\OC_User::getUser());
 			self::$isLoggedIn = true;
 
 			return \OC_User::getUser();
+		} catch (\OC\User\LoginException $e) {
+			return false;
 		}
-
-		return false;
 	}
 
 	/**

diff --git a/lib/private/legacy/user.php b/lib/private/legacy/user.php
@@ -199,9 +199,10 @@ public static function loginWithApache(\OCP\Authentication\IApacheBackend $backe
 				if($setUidAsDisplayName) {
 					self::setDisplayName($uid);
 				}
-				self::getUserSession()->setLoginName($uid);
+				$userSession = self::getUserSession();
+				$userSession->setLoginName($uid);
 				$request = OC::$server->getRequest();
-				self::getUserSession()->createSessionToken($request, $uid, $uid);
+				$userSession->createSessionToken($request, $uid, $uid);
 				// setup the filesystem
 				OC_Util::setupFS($uid);
 				// first call the post_login hooks, the login-process needs to be