CalDavBackend, implement SharingSupport interface.

Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
nextcloud · Feb 17, 2023 · 50c14cc · 50c14cc
1 parent 5219c61
commit 50c14cc
Show file tree

Hide file tree

Showing 2 changed files with 105 additions and 11 deletions.
diff --git a/apps/dav/lib/CalDAV/CalDavBackend.php b/apps/dav/lib/CalDAV/CalDavBackend.php
@@ -80,13 +80,15 @@
 use Sabre\CalDAV\Backend\SchedulingSupport;
 use Sabre\CalDAV\Backend\SubscriptionSupport;
 use Sabre\CalDAV\Backend\SyncSupport;
+use Sabre\CalDAV\Backend\SharingSupport;
 use Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp;
 use Sabre\CalDAV\Xml\Property\SupportedCalendarComponentSet;
 use Sabre\DAV;
 use Sabre\DAV\Exception\BadRequest;
 use Sabre\DAV\Exception\Forbidden;
 use Sabre\DAV\Exception\NotFound;
 use Sabre\DAV\PropPatch;
+use Sabre\DAV\Xml\Element\Sharee;
 use Sabre\Uri;
 use Sabre\VObject\Component;
 use Sabre\VObject\Component\VCalendar;
@@ -118,7 +120,7 @@
  *
  * @package OCA\DAV\CalDAV
  */
-class CalDavBackend extends AbstractBackend implements SyncSupport, SubscriptionSupport, SchedulingSupport {
+class CalDavBackend extends AbstractBackend implements SyncSupport, SubscriptionSupport, SchedulingSupport, SharingSupport {
 	use TTransactional;
 
 	public const CALENDAR_TYPE_CALENDAR = 0;
@@ -362,6 +364,9 @@ public function getCalendarsForUser($principalUri) {
 			$calendar = $this->addOwnerPrincipalToCalendar($calendar);
 			$calendar = $this->addResourceTypeToCalendar($row, $calendar);
 
+			$calendar['{DAV:}share-resource-uri'] = '/ns/share/' . $calendar['id'];
+			$calendar['{DAV:}share-access'] = \Sabre\DAV\Sharing\Plugin::ACCESS_SHAREDOWNER;
+
 			if (!isset($calendars[$calendar['id']])) {
 				$calendars[$calendar['id']] = $calendar;
 			}
@@ -436,6 +441,9 @@ public function getCalendarsForUser($principalUri) {
 			$calendar = $this->addOwnerPrincipalToCalendar($calendar);
 			$calendar = $this->addResourceTypeToCalendar($row, $calendar);
 
+			$calendar['{DAV:}share-resource-uri'] = '/ns/share/' . $calendar['id'];
+			$calendar['{DAV:}share-access'] = $row['access'];
+
 			$calendars[$calendar['id']] = $calendar;
 		}
 		$result->closeCursor();
@@ -658,7 +666,7 @@ public function getCalendarByUri($principal, $uri) {
 	}
 
 	/**
-	 * @return array{id: int, uri: string, '{http://calendarserver.org/ns/}getctag': string, '{http://sabredav.org/ns}sync-token': int, '{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set': SupportedCalendarComponentSet, '{urn:ietf:params:xml:ns:caldav}schedule-calendar-transp': ScheduleCalendarTransp, '{urn:ietf:params:xml:ns:caldav}calendar-timezone': ?string }|null
+	 * @return array{id: int, uri: string, principaluri: string, '{http://calendarserver.org/ns/}getctag': string, '{http://sabredav.org/ns}sync-token': int, '{urn:ietf:params:xml:ns:caldav}supported-calendar-component-set': SupportedCalendarComponentSet, '{urn:ietf:params:xml:ns:caldav}schedule-calendar-transp': ScheduleCalendarTransp, '{urn:ietf:params:xml:ns:caldav}calendar-timezone': ?string }|null
 	 */
 	public function getCalendarById(int $calendarId): ?array {
 		$fields = array_column($this->propertyMap, 0);
@@ -2854,23 +2862,27 @@ public function getShares(int $resourceId): array {
 	}
 
 	/**
-	 * @param boolean $value
-	 * @param \OCA\DAV\CalDAV\Calendar $calendar
-	 * @return string|null
-	 */
-	public function setPublishStatus($value, $calendar) {
-		$calendarId = $calendar->getResourceId();
+     * Publishes a calendar.
+     *
+     * @param mixed $calendarId
+     * @param bool  $value
+     */
+    public function setPublishStatus($calendarId, $value)
+	{
 		$calendarData = $this->getCalendarById($calendarId);
+		if ($calendarData === null) {
+			return;
+		}
 
 		$query = $this->db->getQueryBuilder();
 		if ($value) {
 			$publicUri = $this->random->generate(16, ISecureRandom::CHAR_HUMAN_READABLE);
 			$query->insert('dav_shares')
 				->values([
-					'principaluri' => $query->createNamedParameter($calendar->getPrincipalURI()),
+					'principaluri' => $query->createNamedParameter($calendarData['principaluri']),
 					'type' => $query->createNamedParameter('calendar'),
 					'access' => $query->createNamedParameter(self::ACCESS_PUBLIC),
-					'resourceid' => $query->createNamedParameter($calendar->getResourceId()),
+					'resourceid' => $query->createNamedParameter($calendarId),
 					'publicuri' => $query->createNamedParameter($publicUri)
 				]);
 			$query->executeStatement();
@@ -2913,6 +2925,88 @@ public function applyShareAcl(int $resourceId, array $acl): array {
 		return $this->calendarSharingBackend->applyShareAcl($resourceId, $acl);
 	}
 
+	/**
+     * Updates the list of shares.
+     *
+     * @param mixed                           $calendarId
+     * @param \Sabre\DAV\Xml\Element\Sharee[] $sharees
+	 * @return void
+     */
+    public function updateInvites($calendarId, array $sharees) {
+		$currentShares = $this->getShares($calendarId);
+
+		$removals = [];
+		$additions = [];
+
+		foreach ($sharees as $sharee) {
+            if (\Sabre\DAV\Sharing\Plugin::ACCESS_NOACCESS === $sharee->access) {
+                // if access was set no NOACCESS, it means access for an
+                // existing sharee was removed.
+				$removals[] = $sharee->href;
+                continue;
+            }
+
+            if (is_null($sharee->principal)) {
+                // If the server could not determine the principal automatically,
+                // we will mark the invite status as invalid.
+				continue;
+            }
+
+			$additions[] = [
+				'href' => $sharee->href,
+				'commonName' => $sharee->properties['{DAV:}displayname'] ?? '',
+				'status' => 1,
+				'readOnly' => $sharee->access == \Sabre\DAV\Sharing\Plugin::ACCESS_READ,
+				'{' . \OCA\DAV\DAV\Sharing\Plugin::NS_OWNCLOUD . '}principal' => $sharee->principal,
+				'{' . \OCA\DAV\DAV\Sharing\Plugin::NS_OWNCLOUD . '}group-share' => false,
+			];
+        }
+		// updateShares() needs a IShareable, i.e. a Calendar object. This is
+		// really hacky now ... and inefficient ...
+		$calendarInfo = $this->getCalendarById($calendarId);
+		if ($calendarInfo === null) {
+			return;
+		}
+		$principalUri = $calendarInfo['principaluri'];
+		$calendarUri = $calendarInfo['uri'];
+		$provider = new CalendarProvider($this, \OCP\Util::getL10N('dav'), $this->config, $this->logger);
+		list($shareable,) = $provider->getCalendars($principalUri, [ $calendarUri ]);
+		$this->updateShares($shareable, $additions, $removals);
+	}
+
+	 /**
+     * Returns the list of people whom this calendar is shared with.
+     *
+     * Every item in the returned list must be a Sharee object with at
+     * least the following properties set:
+     *   $href
+     *   $shareAccess
+     *   $inviteStatus
+     *
+     * and optionally:
+     *   $properties
+     *
+     * @param mixed $calendarId
+     *
+     * @return \Sabre\DAV\Xml\Element\Sharee[]
+     */
+    public function getInvites($calendarId) {
+		$shares = $this->getShares($calendarId);
+		$result = [];
+		foreach ($shares as $share) {
+			$result[] = new Sharee([
+				'href' => $share['href'],
+				'access' => $share['readOnly'] ? \Sabre\DAV\Sharing\Plugin::ACCESS_READ : \Sabre\DAV\Sharing\Plugin::ACCESS_READWRITE,
+				'inviteStatus' => \Sabre\DAV\Sharing\Plugin::INVITE_ACCEPTED,
+				'properties' => !empty($share['commonName'])
+					? [ '{DAV:}displayname' => $share['commonName'] ]
+					: [],
+				'principal' => $share['{' . \OCA\DAV\DAV\Sharing\Plugin::NS_OWNCLOUD . '}principal'],
+			]);
+		}
+		return $result;
+	}
+
 	/**
 	 * update properties table
 	 *

diff --git a/apps/dav/lib/CalDAV/Calendar.php b/apps/dav/lib/CalDAV/Calendar.php
@@ -343,7 +343,7 @@ public function calendarQuery(array $filters) {
 	 * @return string|null
 	 */
 	public function setPublishStatus($value) {
-		$publicUri = $this->caldavBackend->setPublishStatus($value, $this);
+		$publicUri = $this->caldavBackend->setPublishStatus($this->getResourceId(), $value);
 		$this->calendarInfo['publicuri'] = $publicUri;
 		return $publicUri;
 	}