Merge pull request #28332 from nextcloud/work/carl/argon2i2

Only recommand for php-sodium on >= PHP 7.4
nextcloud · Aug 31, 2021 · 506b411 · 506b411
2 parents 71c9f4c + 07cccce
commit 506b411
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/apps/settings/lib/Controller/CheckSetupController.php b/apps/settings/lib/Controller/CheckSetupController.php
@@ -627,7 +627,11 @@ protected function hasRecommendedPHPModules(): array {
 			}
 		}
 
-		if (!defined('PASSWORD_ARGON2I')) {
+		if (!defined('PASSWORD_ARGON2I') && PHP_VERSION_ID >= 70400) {
+			// Installing php-sodium on >=php7.4 will provide PASSWORD_ARGON2I
+			// on previous version argon2 wasn't part of the "standard" extension
+			// and RedHat disabled it so even installing php-sodium won't provide argon2i
+			// support in password_hash/password_verify.
 			$recommendedPHPModules[] = 'sodium';
 		}