Skip to content

Commit

Permalink
Update psalm baseline
Browse files Browse the repository at this point in the history 
Signed-off-by: GitHub <noreply@github.com>
  • Loading branch information
@nextcloud-command
nextcloud-command authored Jul 7, 2023
1 parent a9ba19d commit 43a0766
Showing 1 changed file with 72 additions and 78 deletions.
150 changes: 72 additions & 78 deletions build/psalm-baseline.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
</file>
<file src="apps/dav/appinfo/v1/webdav.php">
<InvalidArgument>
<code><![CDATA['OCA\DAV\Connector\Sabre::addPlugin']]></code>
<code>'OCA\DAV\Connector\Sabre::addPlugin'</code>
</InvalidArgument>
<TooManyArguments>
<code>dispatch</code>
Expand Down Expand Up @@ -353,7 +353,7 @@
</RedundantCast>
<RedundantCondition>
<code><![CDATA[!empty($modified['old']) && is_array($modified['old'])]]></code>
<code><![CDATA[is_array($modified['old'])]]></code>
<code>is_array($modified['old'])</code>
</RedundantCondition>
</file>
<file src="apps/dav/lib/CalDAV/Schedule/IMipService.php">
Expand All @@ -364,8 +364,8 @@
</file>
<file src="apps/dav/lib/CalDAV/Schedule/Plugin.php">
<InvalidArgument>
<code><![CDATA[[$aclPlugin, 'propFind']]]></code>
<code><![CDATA[[$aclPlugin, 'propFind']]]></code>
<code>[$aclPlugin, 'propFind']</code>
<code>[$aclPlugin, 'propFind']</code>
</InvalidArgument>
<LessSpecificReturnStatement>
<code><![CDATA[$vevent->DTEND]]></code>
Expand Down Expand Up @@ -400,12 +400,12 @@
</file>
<file src="apps/dav/lib/CalDAV/Search/Xml/Request/CalendarSearchReport.php">
<TypeDoesNotContainType>
<code><![CDATA[!is_array($newProps['filters']['comps'])]]></code>
<code><![CDATA[!is_array($newProps['filters']['params'])]]></code>
<code><![CDATA[!is_array($newProps['filters']['props'])]]></code>
<code><![CDATA[!isset($newProps['filters']['comps']) || !is_array($newProps['filters']['comps'])]]></code>
<code><![CDATA[!isset($newProps['filters']['params']) || !is_array($newProps['filters']['params'])]]></code>
<code><![CDATA[!isset($newProps['filters']['props']) || !is_array($newProps['filters']['props'])]]></code>
<code>!is_array($newProps['filters']['comps'])</code>
<code>!is_array($newProps['filters']['params'])</code>
<code>!is_array($newProps['filters']['props'])</code>
<code>!isset($newProps['filters']['comps']) || !is_array($newProps['filters']['comps'])</code>
<code>!isset($newProps['filters']['params']) || !is_array($newProps['filters']['params'])</code>
<code>!isset($newProps['filters']['props']) || !is_array($newProps['filters']['props'])</code>
</TypeDoesNotContainType>
</file>
<file src="apps/dav/lib/CalDAV/WebcalCaching/RefreshWebcalService.php">
Expand Down Expand Up @@ -441,7 +441,7 @@
<code>VCard</code>
</MoreSpecificReturnType>
<TypeDoesNotContainType>
<code><![CDATA[$addressBooks[$row['id']][$readOnlyPropertyName] === 0]]></code>
<code>$addressBooks[$row['id']][$readOnlyPropertyName] === 0</code>
</TypeDoesNotContainType>
</file>
<file src="apps/dav/lib/CardDAV/MultiGetExportPlugin.php">
Expand Down Expand Up @@ -566,7 +566,7 @@
<code>bool</code>
</InvalidNullableReturnType>
<TooManyArguments>
<code><![CDATA[new PreconditionFailed('Cannot filter by non-existing tag', 0, $e)]]></code>
<code>new PreconditionFailed('Cannot filter by non-existing tag', 0, $e)</code>
</TooManyArguments>
<UndefinedClass>
<code>\OCA\Circles\Api\v1\Circles</code>
Expand Down Expand Up @@ -837,8 +837,8 @@
</file>
<file src="apps/dav/lib/Server.php">
<InvalidArgument>
<code><![CDATA['OCA\DAV\Connector\Sabre::addPlugin']]></code>
<code><![CDATA['OCA\DAV\Connector\Sabre::authInit']]></code>
<code>'OCA\DAV\Connector\Sabre::addPlugin'</code>
<code>'OCA\DAV\Connector\Sabre::authInit'</code>
</InvalidArgument>
<TooManyArguments>
<code>dispatch</code>
Expand Down Expand Up @@ -919,7 +919,7 @@
<code>$userSession</code>
</RedundantCondition>
<TypeDoesNotContainType>
<code><![CDATA[get_class($res) === 'OpenSSLAsymmetricKey']]></code>
<code>get_class($res) === 'OpenSSLAsymmetricKey'</code>
</TypeDoesNotContainType>
</file>
<file src="apps/encryption/lib/Crypto/Encryption.php">
Expand All @@ -939,7 +939,7 @@
</file>
<file src="apps/encryption/lib/Session.php">
<TooManyArguments>
<code><![CDATA[new Exceptions\PrivateKeyMissingException('please try to log-out and log-in again', 0)]]></code>
<code>new Exceptions\PrivateKeyMissingException('please try to log-out and log-in again', 0)</code>
</TooManyArguments>
</file>
<file src="apps/encryption/lib/Util.php">
Expand Down Expand Up @@ -970,7 +970,7 @@
<code>$shareId</code>
<code>$shareId</code>
<code>$shareId</code>
<code><![CDATA[(int)$data['id']]]></code>
<code>(int)$data['id']</code>
</InvalidArgument>
<LessSpecificReturnStatement>
<code>$nodes[0]</code>
Expand Down Expand Up @@ -1005,7 +1005,7 @@
<code>string</code>
</InvalidReturnType>
<InvalidScalarArgument>
<code><![CDATA[(int)$share['id']]]></code>
<code>(int)$share['id']</code>
</InvalidScalarArgument>
</file>
<file src="apps/federation/lib/DbHandler.php">
Expand Down Expand Up @@ -1138,7 +1138,7 @@
</file>
<file src="apps/files/lib/Service/TagService.php">
<InvalidArgument>
<code><![CDATA[self::class . '::' . $eventName]]></code>
<code>self::class . '::' . $eventName</code>
</InvalidArgument>
<TooManyArguments>
<code>dispatch</code>
Expand Down Expand Up @@ -1226,7 +1226,7 @@
</file>
<file src="apps/files_external/lib/Service/BackendService.php">
<InvalidArgument>
<code><![CDATA['OCA\\Files_External::loadAdditionalBackends']]></code>
<code>'OCA\\Files_External::loadAdditionalBackends'</code>
</InvalidArgument>
<TooManyArguments>
<code>dispatch</code>
Expand Down Expand Up @@ -1349,7 +1349,7 @@
</file>
<file src="apps/files_sharing/templates/public.php">
<RedundantCondition>
<code><![CDATA[$_['hideFileList'] !== true]]></code>
<code>$_['hideFileList'] !== true</code>
<code><![CDATA[isset($_['hideFileList']) && $_['hideFileList'] !== true]]></code>
</RedundantCondition>
</file>
Expand Down Expand Up @@ -1397,7 +1397,7 @@
</file>
<file src="apps/files_trashbin/lib/Storage.php">
<InvalidArgument>
<code><![CDATA['OCA\Files_Trashbin::moveToTrash']]></code>
<code>'OCA\Files_Trashbin::moveToTrash'</code>
</InvalidArgument>
<InvalidOperand>
<code><![CDATA[$this->mountPoint]]></code>
Expand Down Expand Up @@ -1552,7 +1552,7 @@
<file src="apps/sharebymail/lib/ShareByMailProvider.php">
<InvalidArgument>
<code><![CDATA[$share->getId()]]></code>
<code><![CDATA[(int)$data['id']]]></code>
<code>(int)$data['id']</code>
</InvalidArgument>
<LessSpecificReturnStatement>
<code>$nodes[0]</code>
Expand Down Expand Up @@ -1652,7 +1652,7 @@
</file>
<file src="apps/user_ldap/lib/AppInfo/Application.php">
<InvalidArgument>
<code><![CDATA['OCA\\User_LDAP\\User\\User::postLDAPBackendAdded']]></code>
<code>'OCA\\User_LDAP\\User\\User::postLDAPBackendAdded'</code>
</InvalidArgument>
<TooManyArguments>
<code>dispatch</code>
Expand Down Expand Up @@ -2034,7 +2034,7 @@
</file>
<file src="lib/private/Accounts/AccountManager.php">
<InvalidArgument>
<code><![CDATA['OC\AccountManager::userUpdated']]></code>
<code>'OC\AccountManager::userUpdated'</code>
</InvalidArgument>
<TooManyArguments>
<code>dispatch</code>
Expand Down Expand Up @@ -2218,7 +2218,7 @@
</file>
<file src="lib/private/AppFramework/Routing/RouteConfig.php">
<InvalidArrayOffset>
<code><![CDATA[$action['url-postfix']]]></code>
<code>$action['url-postfix']</code>
</InvalidArrayOffset>
</file>
<file src="lib/private/AppFramework/Services/AppConfig.php">
Expand Down Expand Up @@ -2452,15 +2452,9 @@
</UndefinedVariable>
</file>
<file src="lib/private/Console/Application.php">
<InvalidArgument>
<code>ConsoleEvent::EVENT_RUN</code>
</InvalidArgument>
<NoInterfaceProperties>
<code><![CDATA[$this->request->server]]></code>
</NoInterfaceProperties>
<TooManyArguments>
<code>dispatch</code>
</TooManyArguments>
</file>
<file src="lib/private/ContactsManager.php">
<InvalidArgument>
Expand Down Expand Up @@ -2496,7 +2490,7 @@
<code>getParams</code>
</InternalMethod>
<InvalidArrayOffset>
<code><![CDATA[$params['collation']]]></code>
<code>$params['collation']</code>
</InvalidArrayOffset>
</file>
<file src="lib/private/DB/Connection.php">
Expand All @@ -2507,8 +2501,8 @@
<code>$params</code>
</InvalidArgument>
<InvalidArrayOffset>
<code><![CDATA[$params['adapter']]]></code>
<code><![CDATA[$params['tablePrefix']]]></code>
<code>$params['adapter']</code>
<code>$params['tablePrefix']</code>
</InvalidArrayOffset>
<InvalidReturnStatement>
<code><![CDATA[$this->adapter->lastInsertId($seqName)]]></code>
Expand Down Expand Up @@ -2560,7 +2554,7 @@
<code>getParams</code>
</InternalMethod>
<InvalidArrayOffset>
<code><![CDATA[$params['collation']]]></code>
<code>$params['collation']</code>
</InvalidArrayOffset>
</file>
<file src="lib/private/DB/QueryBuilder/QueryBuilder.php">
Expand Down Expand Up @@ -2784,10 +2778,10 @@
<code>$user</code>
</InvalidOperand>
<RedundantCondition>
<code><![CDATA[get_class($provider) !== 'OCA\Files_Sharing\MountProvider']]></code>
<code>get_class($provider) !== 'OCA\Files_Sharing\MountProvider'</code>
</RedundantCondition>
<TypeDoesNotContainType>
<code><![CDATA[get_class($provider) === 'OCA\Files_Sharing\MountProvider']]></code>
<code>get_class($provider) === 'OCA\Files_Sharing\MountProvider'</code>
</TypeDoesNotContainType>
</file>
<file src="lib/private/Files/Config/UserMountCache.php">
Expand Down Expand Up @@ -2865,19 +2859,19 @@
</file>
<file src="lib/private/Files/Node/HookConnector.php">
<InvalidArgument>
<code><![CDATA['\OCP\Files::postCopy']]></code>
<code><![CDATA['\OCP\Files::postCreate']]></code>
<code><![CDATA['\OCP\Files::postDelete']]></code>
<code><![CDATA['\OCP\Files::postRename']]></code>
<code><![CDATA['\OCP\Files::postTouch']]></code>
<code><![CDATA['\OCP\Files::postWrite']]></code>
<code><![CDATA['\OCP\Files::preCopy']]></code>
<code><![CDATA['\OCP\Files::preCreate']]></code>
<code><![CDATA['\OCP\Files::preDelete']]></code>
<code><![CDATA['\OCP\Files::preRename']]></code>
<code><![CDATA['\OCP\Files::preTouch']]></code>
<code><![CDATA['\OCP\Files::preWrite']]></code>
<code><![CDATA['\OCP\Files::read']]></code>
<code>'\OCP\Files::postCopy'</code>
<code>'\OCP\Files::postCreate'</code>
<code>'\OCP\Files::postDelete'</code>
<code>'\OCP\Files::postRename'</code>
<code>'\OCP\Files::postTouch'</code>
<code>'\OCP\Files::postWrite'</code>
<code>'\OCP\Files::preCopy'</code>
<code>'\OCP\Files::preCreate'</code>
<code>'\OCP\Files::preDelete'</code>
<code>'\OCP\Files::preRename'</code>
<code>'\OCP\Files::preTouch'</code>
<code>'\OCP\Files::preWrite'</code>
<code>'\OCP\Files::read'</code>
</InvalidArgument>
<TooManyArguments>
<code>dispatch</code>
Expand Down Expand Up @@ -2925,7 +2919,7 @@
</file>
<file src="lib/private/Files/Node/Node.php">
<InvalidArgument>
<code><![CDATA['\OCP\Files::' . $hook]]></code>
<code>'\OCP\Files::' . $hook</code>
</InvalidArgument>
<InvalidNullableReturnType>
<code>FileInfo</code>
Expand Down Expand Up @@ -2998,7 +2992,7 @@
<code>Promise\promise_for(
new Credentials($key, $secret)
)</code>
<code><![CDATA[\Aws\or_chain([self::class, 'legacySignatureProvider'], ClientResolver::_default_signature_provider())]]></code>
<code>\Aws\or_chain([self::class, 'legacySignatureProvider'], ClientResolver::_default_signature_provider())</code>
</UndefinedFunction>
</file>
<file src="lib/private/Files/ObjectStore/S3ObjectTrait.php">
Expand Down Expand Up @@ -3215,12 +3209,12 @@
</file>
<file src="lib/private/Group/Group.php">
<InvalidArgument>
<code><![CDATA[IGroup::class . '::postAddUser']]></code>
<code><![CDATA[IGroup::class . '::postDelete']]></code>
<code><![CDATA[IGroup::class . '::postRemoveUser']]></code>
<code><![CDATA[IGroup::class . '::preAddUser']]></code>
<code><![CDATA[IGroup::class . '::preDelete']]></code>
<code><![CDATA[IGroup::class . '::preRemoveUser']]></code>
<code>IGroup::class . '::postAddUser'</code>
<code>IGroup::class . '::postDelete'</code>
<code>IGroup::class . '::postRemoveUser'</code>
<code>IGroup::class . '::preAddUser'</code>
<code>IGroup::class . '::preDelete'</code>
<code>IGroup::class . '::preRemoveUser'</code>
<code>bool</code>
</InvalidArgument>
<InvalidOperand>
Expand Down Expand Up @@ -3290,8 +3284,8 @@
<code>false</code>
</InvalidArgument>
<InvalidArrayOffset>
<code><![CDATA[$app['path']]]></code>
<code><![CDATA[$app['path']]]></code>
<code>$app['path']</code>
<code>$app['path']</code>
</InvalidArrayOffset>
<NullArgument>
<code>null</code>
Expand Down Expand Up @@ -3664,8 +3658,8 @@
</file>
<file src="lib/private/Setup.php">
<RedundantCondition>
<code><![CDATA[$content !== '']]></code>
<code><![CDATA[$type === 'pdo']]></code>
<code>$content !== ''</code>
<code>$type === 'pdo'</code>
</RedundantCondition>
<UndefinedVariable>
<code>$vendor</code>
Expand Down Expand Up @@ -3695,7 +3689,7 @@
<InvalidArgument>
<code><![CDATA[$share->getId()]]></code>
<code><![CDATA[$share->getId()]]></code>
<code><![CDATA[(int)$data['id']]]></code>
<code>(int)$data['id']</code>
</InvalidArgument>
<TooManyArguments>
<code>set</code>
Expand All @@ -3707,12 +3701,12 @@
<file src="lib/private/Share20/Manager.php">
<InvalidArgument>
<code>$id</code>
<code><![CDATA['OCP\Share::postAcceptShare']]></code>
<code><![CDATA['OCP\Share::postShare']]></code>
<code><![CDATA['OCP\Share::postUnshare']]></code>
<code><![CDATA['OCP\Share::postUnshareFromSelf']]></code>
<code><![CDATA['OCP\Share::preShare']]></code>
<code><![CDATA['OCP\Share::preUnshare']]></code>
<code>'OCP\Share::postAcceptShare'</code>
<code>'OCP\Share::postShare'</code>
<code>'OCP\Share::postUnshare'</code>
<code>'OCP\Share::postUnshareFromSelf'</code>
<code>'OCP\Share::preShare'</code>
<code>'OCP\Share::preUnshare'</code>
</InvalidArgument>
<TooManyArguments>
<code>dispatch</code>
Expand Down Expand Up @@ -3909,7 +3903,7 @@
<code>boolean|null</code>
</ImplementedReturnTypeMismatch>
<InvalidArgument>
<code><![CDATA[IUser::class . '::firstLogin']]></code>
<code>IUser::class . '::firstLogin'</code>
</InvalidArgument>
<NoInterfaceProperties>
<code><![CDATA[$request->server]]></code>
Expand All @@ -3921,11 +3915,11 @@
</file>
<file src="lib/private/User/User.php">
<InvalidArgument>
<code><![CDATA[IUser::class . '::changeUser']]></code>
<code><![CDATA[IUser::class . '::postDelete']]></code>
<code><![CDATA[IUser::class . '::postSetPassword']]></code>
<code><![CDATA[IUser::class . '::preDelete']]></code>
<code><![CDATA[IUser::class . '::preSetPassword']]></code>
<code>IUser::class . '::changeUser'</code>
<code>IUser::class . '::postDelete'</code>
<code>IUser::class . '::postSetPassword'</code>
<code>IUser::class . '::preDelete'</code>
<code>IUser::class . '::preSetPassword'</code>
</InvalidArgument>
<TooManyArguments>
<code>dispatch</code>
Expand Down Expand Up @@ -3956,8 +3950,8 @@
<code>ManagerEvent::EVENT_APP_UPDATE</code>
</InvalidArgument>
<InvalidArrayOffset>
<code><![CDATA[$dir['path']]]></code>
<code><![CDATA[$dir['url']]]></code>
<code>$dir['path']</code>
<code>$dir['url']</code>
</InvalidArrayOffset>
<NullArgument>
<code>null</code>
Expand Down

0 comments on commit 43a0766

Please sign in to comment.