fix(files_sharing): fix label usage of file request feature

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
nextcloud · Jul 12, 2024 · 3997925 · 3997925
1 parent a8bdf4a
commit 3997925
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/apps/files_sharing/src/components/NewFileRequestDialog.vue b/apps/files_sharing/src/components/NewFileRequestDialog.vue
@@ -22,7 +22,8 @@
 		<!-- Main form -->
 		<form ref="form"
 			class="file-request-dialog__form"
-			aria-labelledby="file-request-dialog-description"
+			aria-describedby="file-request-dialog-description"
+			:aria-label="t('files_sharing', 'File request')"
 			aria-live="polite"
 			data-cy-file-request-dialog-form
 			@submit.prevent.stop="">
@@ -69,7 +70,7 @@
 				data-cy-file-request-dialog-controls="back"
 				type="tertiary"
 				@click="currentStep = STEP.FIRST">
-				{{ t('files_sharing', 'Previous') }}
+				{{ t('files_sharing', 'Previous step') }}
 			</NcButton>
 
 			<!-- Next -->

diff --git a/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogDatePassword.vue b/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogDatePassword.vue
@@ -30,6 +30,7 @@
 				id="file-request-dialog-expirationDate"
 				:disabled="disabled"
 				:hide-label="true"
+				:label="t('files_sharing', 'Expiration date')"
 				:max="maxDate"
 				:min="minDate"
 				:placeholder="t('files_sharing', 'Select a date')"
@@ -59,7 +60,7 @@
 				<NcPasswordField ref="passwordField"
 					:check-password-strength="true"
 					:disabled="disabled"
-					:label-outside="true"
+					:label="t('files_sharing', 'Password')"
 					:placeholder="t('files_sharing', 'Enter a valid password')"
 					:required="false"
 					:value="password"

diff --git a/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogFinish.vue b/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogFinish.vue
@@ -20,8 +20,8 @@
 			@click="copyShareLink"
 			@click-trailing-button="copyShareLink">
 			<template #trailing-button-icon>
-				<IconCheck v-if="isCopied" :size="20" @click="isCopied = false" />
-				<IconClipboard v-else :size="20" @click="copyShareLink" />
+				<IconCheck v-if="isCopied" :size="20" />
+				<IconClipboard v-else :size="20" />
 			</template>
 		</NcInputField>
 

diff --git a/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogIntro.vue b/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogIntro.vue
@@ -12,7 +12,7 @@
 			</legend>
 			<NcTextField :value="label"
 				:disabled="disabled"
-				:label-outside="true"
+				:label="t('files_sharing', 'Request subject')"
 				:placeholder="t('files_sharing', 'Birthday party photos, History assignment…')"
 				:required="false"
 				name="label"
@@ -27,7 +27,7 @@
 			<NcTextField :value="destination"
 				:disabled="disabled"
 				:helper-text="t('files_sharing', 'The uploaded files are visible only to you unless you choose to share them.')"
-				:label-outside="true"
+				:label="t('files_sharing', 'Upload destination')"
 				:minlength="2/* cannot share root */"
 				:placeholder="t('files_sharing', 'Select a destination')"
 				:readonly="false /* cannot validate a readonly input */"
@@ -51,7 +51,7 @@
 			</legend>
 			<NcTextArea :value="note"
 				:disabled="disabled"
-				:label-outside="true"
+				:label="t('files_sharing', 'Note for recipient')"
 				:placeholder="t('files_sharing', 'Add a note to help people understand what you are requesting.')"
 				:required="false"
 				name="note"