Add unit test for case insensitive email saving

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
nextcloud · Dec 16, 2022 · 28aaa5a · 28aaa5a
1 parent ff6279e
commit 28aaa5a
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/apps/settings/tests/Controller/UsersControllerTest.php b/apps/settings/tests/Controller/UsersControllerTest.php
@@ -624,7 +624,7 @@ public function testSaveUserSettings($data,
 		$user->method('getSystemEMailAddress')->willReturn($oldEmailAddress);
 		$user->method('canChangeDisplayName')->willReturn(true);
 
-		if ($data[IAccountManager::PROPERTY_EMAIL]['value'] === $oldEmailAddress ||
+		if (strtolower($data[IAccountManager::PROPERTY_EMAIL]['value']) === strtolower($oldEmailAddress) ||
 			($oldEmailAddress === null && $data[IAccountManager::PROPERTY_EMAIL]['value'] === '')) {
 			$user->expects($this->never())->method('setSystemEMailAddress');
 		} else {
@@ -720,6 +720,14 @@ public function dataTestSaveUserSettings() {
 				'john@example.com',
 				null
 			],
+			[
+				[
+					IAccountManager::PROPERTY_EMAIL => ['value' => 'john@example.com'],
+					IAccountManager::PROPERTY_DISPLAYNAME => ['value' => 'john doe'],
+				],
+				'JOHN@example.com',
+				null
+			],
 
 		];
 	}