Merge pull request #34111 from nextcloud/backport/34073/stable24

[stable24] dont try email login if the provider username is not a valid email
nextcloud · Sep 27, 2022 · 20cd49c · 20cd49c
2 parents 1ac1aff + fbebc4b
commit 20cd49c
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/lib/private/User/Session.php b/lib/private/User/Session.php
@@ -450,6 +450,9 @@ public function logClientIn($user,
 		if (!$this->login($user, $password)) {
 
 			// Failed, maybe the user used their email address
+			if (!filter_var($user, FILTER_VALIDATE_EMAIL)) {
+				return false;
+			}
 			$users = $this->manager->getByEmail($user);
 			if (!(\count($users) === 1 && $this->login($users[0]->getUID(), $password))) {
 				$this->logger->warning('Login failed: \'' . $user . '\' (Remote IP: \'' . \OC::$server->getRequest()->getRemoteAddress() . '\')', ['app' => 'core']);