Merge pull request #35071 from nextcloud/fix/384-missing_alt_text_for…

…_logo_on_multiple_pages Add alt to the logo, adapt css for logo
nextcloud · Dec 8, 2022 · 11d7cd0 · 11d7cd0
2 parents fa7364e + bba5ab0
commit 11d7cd0
Show file tree

Hide file tree

Showing 10 changed files with 15 additions and 41 deletions.
diff --git a/core/css/guest.css b/core/css/guest.css
@@ -82,12 +82,9 @@ body {
 }
 
 #header .logo {
-	background-image: var(--image-logo, url('../../core/img/logo/logo.svg'));
-	background-repeat: no-repeat;
-	background-size: contain;
-	background-position: center;
-	width: 175px;
-	height: 130px;
+	max-width: 175px;
+	width: auto;
+	max-height: 130px;
 	margin: 0 auto;
 	position: relative;
 	left: unset;

diff --git a/core/css/header.css b/core/css/header.css
diff --git a/core/css/header.css.map b/core/css/header.css.map
diff --git a/core/css/header.scss b/core/css/header.scss
@@ -163,15 +163,9 @@
 	}
 	.logo {
 		display: inline-flex;
-		background-image: var(--image-logoheader, var(--image-logo, url('../img/logo/logo.svg')));
-		background-repeat: no-repeat;
-		background-size: contain;
-		background-position: center;
 		width: 62px;
 		position: absolute;
 		left: 12px;
-		top: 1px;
-		bottom: 1px;
 		// Invert if not customized and background is bright
 		filter: var(--image-logoheader-custom, var(--background-image-invert-if-bright));
 	}

diff --git a/core/css/server.css b/core/css/server.css
diff --git a/core/css/server.css.map b/core/css/server.css.map
diff --git a/core/templates/layout.guest.php b/core/templates/layout.guest.php
@@ -35,7 +35,8 @@
 				<?php if ($_['bodyid'] === 'body-login'): ?>
 					<header role="banner">
 						<div id="header">
-							<div class="logo"></div>
+
+							<img class="logo" alt="<?php p($l->t('%s logo', [$theme->getName()])); ?>" src="<?= ($_['logoUrl'] ?? '') !== '' ? $_['logoUrl'] : $theme->getLogo(); ?>">
 						</div>
 					</header>
 				<?php endif; ?>

diff --git a/core/templates/layout.public.php b/core/templates/layout.public.php
@@ -37,15 +37,8 @@
 	</div>
 
 	<header id="header">
-		<div class="header-left">
-			<div class="logo logo-icon svg"></div>
-			<span id="nextcloud" class="header-appname">
-				<?php if (isset($template) && $template->getHeaderTitle() !== '') { ?>
-					<?php p($template->getHeaderTitle()); ?>
-				<?php } else { ?>
-					<?php	p($theme->getName()); ?>
-				<?php } ?>
-			</span>
+		<div class="header-left" id="nextcloud">
+			<img class="logo logo-icon svg" alt="<?php p($l->t('%s logo', [$theme->getName()])); ?>" src="<?= ($_['logoUrl'] ?? '') !== '' ? $_['logoUrl'] : $theme->getLogo(); ?>">
 			<?php if (isset($template) && $template->getHeaderDetails() !== '') { ?>
 				<div class="header-shared-by">
 					<?php p($template->getHeaderDetails()); ?>

diff --git a/core/templates/layout.user.php b/core/templates/layout.user.php
@@ -60,7 +60,7 @@
 			<div class="header-left">
 				<a href="<?php print_unescaped($_['logoUrl'] ?: link_to('', 'index.php')); ?>"
 					id="nextcloud">
-					<div class="logo logo-icon"></div>
+					<img class="logo logo-icon" alt="<?php p($l->t('%s logo', [$theme->getName()])); ?>" src="<?= ($_['logoUrl'] ?? '') !== '' ? $_['logoUrl'] : $theme->getLogo(); ?>">
 				</a>
 
 				<nav id="header-left__appmenu"></nav>

diff --git a/lib/private/TemplateLayout.php b/lib/private/TemplateLayout.php
@@ -120,10 +120,6 @@ public function __construct($renderAs, $appId = '') {
 				$this->assign('enabledThemes', $themesService->getEnabledThemes());
 			}
 
-			// set logo link target
-			$logoUrl = $this->config->getSystemValueString('logo_url', '');
-			$this->assign('logoUrl', $logoUrl);
-
 			// Add navigation entry
 			$this->assign('application', '');
 			$this->assign('appid', $appId);
@@ -194,6 +190,11 @@ public function __construct($renderAs, $appId = '') {
 		} else {
 			parent::__construct('core', 'layout.base');
 		}
+
+		// set logo link target
+		$logoUrl = $this->config->getSystemValueString('logo_url', '');
+		$this->assign('logoUrl', $logoUrl);
+
 		// Send the language and the locale to our layouts
 		$lang = \OC::$server->getL10NFactory()->findLanguage();
 		$locale = \OC::$server->getL10NFactory()->findLocale($lang);