fix(proxy): reaching s3 storage behind some http proxy

Signed-off-by: Maxime Besson <maxime.besson@worteks.com>
nextcloud · Apr 9, 2021 · 03fe74b · 03fe74b
1 parent 32551b9
commit 03fe74b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/lib/private/Files/ObjectStore/S3ConnectionTrait.php b/lib/private/Files/ObjectStore/S3ConnectionTrait.php
@@ -57,6 +57,9 @@ trait S3ConnectionTrait {
 	/** @var int */
 	protected $timeout;
 
+	/** @var string */
+	protected $proxy;
+
 	/** @var int */
 	protected $uploadPartSize;
 
@@ -71,6 +74,7 @@ protected function parseParams($params) {
 
 		$this->test = isset($params['test']);
 		$this->bucket = $params['bucket'];
+		$this->proxy = isset($params['proxy']) ? $params['proxy'] : false;
 		$this->timeout = !isset($params['timeout']) ? 15 : $params['timeout'];
 		$this->uploadPartSize = !isset($params['uploadPartSize']) ? 524288000 : $params['uploadPartSize'];
 		$params['region'] = empty($params['region']) ? 'eu-west-1' : $params['region'];
@@ -86,6 +90,10 @@ public function getBucket() {
 		return $this->bucket;
 	}
 
+	public function getProxy() {
+		return $this->proxy;
+	}
+
 	/**
 	 * Returns the connection
 	 *
@@ -123,7 +131,7 @@ public function getConnection() {
 			'csm' => false,
 		];
 		if (isset($this->params['proxy'])) {
-			$options['request.options'] = ['proxy' => $this->params['proxy']];
+			$options['http'] = [ 'proxy' => $this->params['proxy'] ];
 		}
 		if (isset($this->params['legacy_auth']) && $this->params['legacy_auth']) {
 			$options['signature_version'] = 'v2';

diff --git a/lib/private/Files/ObjectStore/S3ObjectTrait.php b/lib/private/Files/ObjectStore/S3ObjectTrait.php
@@ -51,7 +51,8 @@ abstract protected function getConnection();
 	 */
 	public function readObject($urn) {
 		return SeekableHttpStream::open(function ($range) use ($urn) {
-			$command = $this->getConnection()->getCommand('GetObject', [
+			$connection = $this->getConnection();
+			$command = $connection->getCommand('GetObject', [
 				'Bucket' => $this->bucket,
 				'Key' => $urn,
 				'Range' => 'bytes=' . $range,
@@ -70,6 +71,10 @@ public function readObject($urn) {
 				],
 			];
 
+			if ($connection->getProxy()) {
+				$opts['http']['proxy'] = $connection->getProxy();
+			}
+
 			$context = stream_context_create($opts);
 			return fopen($request->getUri(), 'r', false, $context);
 		});