Refactor lib/private #27968
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
static-code-analysis.yml
on: pull_request
static-code-analysis
2m 56s
static-code-analysis-security
6m 4s
static-code-analysis-ocp
1m 50s
Annotations
20 errors
ImplementedReturnTypeMismatch:
lib/private/TagManager.php#L61
lib/private/TagManager.php:61:13: ImplementedReturnTypeMismatch: The inherited return type 'OCP\ITags' for OCP\ITagManager::load is different to the implemented return type for OC\TagManager::load 'OC\Tags|null' (see https://psalm.dev/123)
|
MoreSpecificImplementedParamType:
lib/private/TagManager.php#L66
lib/private/TagManager.php:66:73: MoreSpecificImplementedParamType: Argument 4 of OC\TagManager::load has the more specific type 'null', expecting 'null|string' as defined by OCP\ITagManager::load (see https://psalm.dev/140)
|
ImplementedReturnTypeMismatch:
lib/private/TempManager.php#L78
lib/private/TempManager.php:78:13: ImplementedReturnTypeMismatch: The inherited return type 'string' for OCP\ITempManager::getTemporaryFile is different to the implemented return type for OC\TempManager::gettemporaryfile 'bool|string' (see https://psalm.dev/123)
|
ImplementedReturnTypeMismatch:
lib/private/TempManager.php#L115
lib/private/TempManager.php:115:13: ImplementedReturnTypeMismatch: The inherited return type 'string' for OCP\ITempManager::getTemporaryFolder is different to the implemented return type for OC\TempManager::gettemporaryfolder 'bool|string' (see https://psalm.dev/123)
|
InvalidScalarArgument:
lib/private/TemplateLayout.php#L287
lib/private/TemplateLayout.php:287:23: InvalidScalarArgument: Argument 1 of str_contains expects string, but bool|string provided (see https://psalm.dev/012)
|
InvalidScalarArgument:
lib/private/TemplateLayout.php#L323
lib/private/TemplateLayout.php:323:41: InvalidScalarArgument: Argument 1 of OC\TemplateLayout::getAppNamefromPath expects string, but non-empty-string|true provided (see https://psalm.dev/012)
|
InvalidScalarArgument:
lib/private/TemplateLayout.php#L331
lib/private/TemplateLayout.php:331:41: InvalidScalarArgument: Argument 1 of OC\TemplateLayout::getAppNamefromPath expects string, but non-empty-string|true provided (see https://psalm.dev/012)
|
RedundantCondition:
lib/private/TemplateLayout.php#L358
lib/private/TemplateLayout.php:358:7: RedundantCondition: Type non-empty-string for $path is always string (see https://psalm.dev/122)
|
RedundantCondition:
lib/private/TemplateLayout.php#L358
lib/private/TemplateLayout.php:358:23: RedundantCondition: Type non-empty-string for $path is always string (see https://psalm.dev/122)
|
static-code-analysis
Process completed with exit code 2.
|
TaintedHtml:
apps/admin_audit/lib/Actions/Action.php#L62
apps/admin_audit/lib/Actions/Action.php:62:16: TaintedHtml: Detected tainted HTML (see https://psalm.dev/245)
|
TaintedCallable:
apps/files_external/lib/Config/ConfigAdapter.php#L85
apps/files_external/lib/Config/ConfigAdapter.php:85:50: TaintedCallable: Detected tainted text (see https://psalm.dev/243)
|
TaintedFile:
apps/files_external/lib/Lib/Storage/SFTP.php#L237
apps/files_external/lib/Lib/Storage/SFTP.php:237:17: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)
|
TaintedFile:
apps/files_external/lib/Lib/Storage/SFTP.php#L258
apps/files_external/lib/Lib/Storage/SFTP.php:258:19: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)
|
TaintedFile:
apps/files_external/lib/Lib/Storage/SFTP.php#L399
apps/files_external/lib/Lib/Storage/SFTP.php:399:22: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)
|
TaintedCookie:
apps/files_sharing/lib/Controller/ShareController.php#L501
apps/files_sharing/lib/Controller/ShareController.php:501:35: TaintedCookie: Detected tainted cookie (see https://psalm.dev/257)
|
TaintedFile:
apps/theming/lib/IconBuilder.php#L137
apps/theming/lib/IconBuilder.php:137:40: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)
|
TaintedFile:
apps/theming/lib/IconBuilder.php#L235
apps/theming/lib/IconBuilder.php:235:28: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)
|
TaintedHeader:
lib/base.php#L206
lib/base.php:206:12: TaintedHeader: Detected tainted header (see https://psalm.dev/256)
|
TaintedHeader:
lib/base.php#L288
lib/base.php:288:12: TaintedHeader: Detected tainted header (see https://psalm.dev/256)
|