groupfolders support #225
Merged
groupfolders support #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ArtificialOwl
commented
May 7, 2023
•
ArtificialOwl
commented
- when browsing files, adding groupfolders' groups/circles to list of shares recipient if current file is in groupfolder when searching for related resources
- returns groupfolder as related resources when browsing related items
- generate link to the correct groupfolder
- front-end ?
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
support-groupfolders
branch
from
8012228
to
39744bb
Compare
|
2 UI aspects that need polishing: 
@Pytal can you take care of this one, priority is higher then A11Y since we would need this for RC1 |
AndyScherzinger
added
2. developing
|
can we review, merge and implements modification to front-end in another PR ? |
|
Yes, absolutely 👍 |
come-nc
reviewed
May 15, 2023
lib/RelatedResourceProviders/GroupFoldersRelatedResourceProvider.php
Outdated
Show resolved
Hide resolved
lib/RelatedResourceProviders/GroupFoldersRelatedResourceProvider.php
Outdated
Show resolved
Hide resolved
lib/RelatedResourceProviders/GroupFoldersRelatedResourceProvider.php
Outdated
Show resolved
Hide resolved
Signed-off-by: Christopher Ng <chrng8@gmail.com>
This was referenced May 15, 2023
Fix groupfolder icon color
|
ℹ️ Front-end work was merged into this branch |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
approved these changes
May 16, 2023
|
Good for me, waiting for CI |
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.