-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(dashboard): implement widget item api v2 #641
Conversation
f526a33
to
29517ff
Compare
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
f903e5e
to
52feace
Compare
/backport to stable27 |
This comment was marked as resolved.
This comment was marked as resolved.
I've noticed a small feature regression. The old Vue widget allowed me to click on the preview of an image and open the file in the Viewer. The new API widget only offers a link to the file. Could that be a problem? |
The feature was added with 800310a. So cc @juliushaertl |
Would be nice to have this back to avoid full page loads whenever possible, but probably less critical with 28 where the files app becomes a lot faster in loading with vue. |
@jancborchardt @marcoambrosini @nimishavijay is it sufficient to have a quick files app and navigating to the recommended file or shall we revive the less performant widget with the direct viewer integration? |
Direct viewer integration is a much much nicer experience. (Otherwise the dashboard is always only a clunky jumping-off point instead of making it seamless.) Can we do that and get it more performant? |
We can't. The new, performant widgets only work with standard lists. For the Viewer integration we need our own script. |
Let's revert this PR @st3iny In the future we might be able to advance the widget APIs again for an option to open Viewer for the thumbnail of an entry. |
Ref nextcloud/server#39937