-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polls app takes for granted that it lives under /apps #249
Comments
I assume the same problem as other installations have with the NC core generated css files. We should switch back from SCSS to CSS. |
Same problem with Deck and Contacts app? |
Indeed, Deck and Contacts (see nextcloud/contacts#439) also have presentation issues, although I had not thought about the similarity until you pointed it out! I will try to apply the same “solution” (see #230) to those two apps… |
@juliushaertl didn't you recently make a PR related to this? |
Nope, but it looks like nextcloud/server#5289. @kyrofa mentioned on IRC that he is working on a fix for that. |
Indeed this looks the same-- the bug only bites with scss. I have a failing unit test, just driving toward a solution. Note that the test already passes on master, so it seems this issue has been fixed there. It's just broken in v12. Can you verify? |
Just tested my fix, it works. I'll clean it up and propose it either later tonight or in the morning. |
Please take a look at nextcloud/server#7257 . |
Thank you, @kyrofa. Unfortunately, this does not seem to fix things for me. I downloaded https://github.com/nextcloud/server/pull/7257.patch and applied the patch on my Nextcloud installation:
I also re-enabled the SCSS files:
Finally, I made sure to restart the server:
Neither Contacts nor Polls sees any improvement over the result from the original code. |
@tYYGH I noticed this in your config file:
Could it be the fact that your apps location is not |
It depends on which “apps” you talk about ;-)
|
See #250 (comment) |
Steps to reproduce
/usr
, with writeable data in/var/lib/nextcloud
:/usr
,/var/lib/nextcloud/apps
./var/lib/nextcloud/apps/polls
, associated with URL prefix/xapps/polls
.Expected behaviour
URLs to
/…/polls/img/*.svg
(yes-vote, no-vote…) should depend on the path of the app itself, in my case/xapps/polls
.Actual behaviour
URLs to
/…/polls/img/*.svg
(yes-vote, no-vote…) are hard-coded to be/apps/polls/img/*.svg
.Server configuration
See here:
nextcloud/server#7037
Browser console:
502 bad gateway
for the SVG files.Nginx console:
[error] 9068#9068: *38300 upstream prematurely closed connection while reading response header from upstream, client: 192.168.1.99, server: , request: "GET /apps/polls/img/no-vote.svg HTTP/1.1", upstream: "uwsgi://unix:/run/nextcloud:", host: "yalis.fr"
uwsgi console:
GET /apps/polls/img/no-vote.svg => generated 0 bytes in 0 msecs (HTTP/1.1 500)
The text was updated successfully, but these errors were encountered: