Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we have a valid fileID for albums content and fix trashbin listener event #1279

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Make sure we have a valid fileID for albums content and fix trashbin listener event #1279

merged 2 commits into from
Sep 23, 2022

Conversation

skjnldsv
Copy link
Member

Signed-off-by: John Molakvoæ skjnldsv@protonmail.com

@skjnldsv skjnldsv self-assigned this Sep 22, 2022
@skjnldsv skjnldsv added 3. to review Waiting for reviews bug Something isn't working labels Sep 22, 2022
@skjnldsv skjnldsv added this to the Nextcloud 25 milestone Sep 22, 2022
artonge
artonge approved these changes Sep 22, 2022
View reviewed changes
Copy link
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which context can this happen?

@blizzz blizzz mentioned this pull request Sep 22, 2022
Merged
2 tasks
@skjnldsv
Copy link
Member Author

Which context can this happen?

File put to trashbin

@skjnldsv
Copy link
Member Author

/rebase

@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@skjnldsv
Copy link
Member Author

/compile amend /

@skjnldsv
Copy link
Member Author

/backport to stable25

@skjnldsv
Copy link
Member Author

/backport to stable25

@skjnldsv
Make sure we have a valid fileID for albums content
d5062f4 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
Fix Trashbin deletion event
e737b08 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv changed the title Make sure we have a valid fileID for albums content Make sure we have a valid fileID for albums contentand fix trashbin event Sep 22, 2022
@skjnldsv skjnldsv changed the title Make sure we have a valid fileID for albums contentand fix trashbin event Make sure we have a valid fileID for albums content and fix trashbin listener event Sep 22, 2022
@skjnldsv skjnldsv added the high High priority label Sep 22, 2022
@skjnldsv skjnldsv merged commit 75d4da8 into master Sep 23, 2022
@skjnldsv skjnldsv deleted the fix/invalid-fileid branch September 23, 2022 07:30
@skjnldsv
Copy link
Member Author

/backport to stable25

skjnldsv added a commit that referenced this pull request Sep 23, 2022
@skjnldsv
Merge pull request #1279 from nextcloud/fix/invalid-fileid
aa5a1b5 
Make sure we have a valid fileID for albums content and fix trashbin listener event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working high High priority
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @artonge @blizzz