Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deprecations): use @nextcloud/router for generateUrl #549

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deprecations): use @nextcloud/router for generateUrl #549

wants to merge 1 commit into from

Conversation

max-nextcloud
Copy link
Contributor

  • Target version: main

Summary

fix some deprecations

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation is not required

@max-nextcloud
chore(deprecations): use @nextcloud/router for generateUrl
36c3b06 
Signed-off-by: Max <max@nextcloud.com>
Base automatically changed from fix/load-sharing-create-file to main April 17, 2024 11:18
@juliusknorr
Copy link
Member

Thanks, will give it a quick spin later because I remembered some difference in handling trailing slashes in the library at some point when switching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-nextcloud @juliusknorr