Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken calls for inline script support #526

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Feb 23, 2024

  • chore: Remove unused direct editor implementation
  • fix: Set allowed script domain instead of inline script

Otherwise editing is broken on 27/28 due to the a faulty earlier change on removed APIs

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr changed the title fix/csp inline Fix broken calls for inline script support Mar 14, 2024
@juliusknorr juliusknorr added 3. to review Waiting for reviews bug Something isn't working labels Mar 14, 2024
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look sensible. Didn't test though.

@juliusknorr juliusknorr merged commit 0df331a into main Mar 18, 2024
28 checks passed
@juliusknorr juliusknorr deleted the fix/csp-inline branch March 18, 2024 07:44
@joshtrichards joshtrichards linked an issue Mar 27, 2024 that may be closed by this pull request
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when opening an office document with office online over an public link
2 participants