Debug missing notification bell #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
skjnldsv
reviewed
May 21, 2021
| @@ -135,6 +135,7 @@ export default { | |||
| }, | |||
|
|
|||
| beforeMount() { | |||
| console.debug('Loading theming data for notification bell styling') | |||
There was a problem hiding this comment.
Could you use @nextcloud/logger? :)
There was a problem hiding this comment.
Something is preventing the app to continue. I'd like to avoid loading more dependencies just to find out what and then revert it 😬
|
Looks good 👍 Or what do you expect me to say? 🥳 It's debug log after all 😆 |
MorrisJobke
approved these changes
May 25, 2021
98 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't find out why the browser sometimes kills notifications when it was in hypernate oder the computer was in hypernate, or shutdown or whatever. So this is adding some spamy logs for now and as soon as we found out we can remove them where it is too much spam