Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: migrate from Webpack to Vite #2002

Merged
merged 8 commits into from
Aug 14, 2024
Merged

build: migrate from Webpack to Vite #2002

merged 8 commits into from
Aug 14, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Aug 12, 2024

  • Migrate from Webpack to Vite, including:
    • Using ESBuild
    • Extracting CSS
Metric Before After
Build time 16s 9s
main page size 4 MB 1.3 MB JS + 0.01 MB CSS
settings page size 3.7 MB 0.6 MB JS + 0.07 MB CSS
admin-settings page size 3.6 MB 0.5 MB JS + 0.04 MB CSS
total size 6.4 MB 1.4 MB JS + 0.12 MB CSS

@ShGKme
chore(devDeps): replace Webpack dependencies with Vite
1d7f498 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added this to the Nextcloud 30 milestone Aug 12, 2024
@ShGKme ShGKme self-assigned this Aug 12, 2024
@ShGKme
Copy link
Contributor Author

ShGKme commented Aug 12, 2024

Checking reuse

@ShGKme ShGKme force-pushed the build/vite branch 2 times, most recently from bc1b0a6 to 6179314 Compare August 12, 2024 20:34
@nickvergessen
Copy link
Member

Checking reuse

Add css/**.css to https://github.com/nextcloud/notifications/blob/master/REUSE.toml#L15 ?

@ShGKme
Copy link
Contributor Author

ShGKme commented Aug 12, 2024 •
edited
Loading

Checking reuse

Add css/**.css to https://github.com/nextcloud/notifications/blob/master/REUSE.toml#L15 ?

Not only. Also .map files in for .mjs and vendor.licenses.txt

@ShGKme
build: replace Webpack config with Vite config
369a721 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
build: add extracted styles in templates
5e9b80b 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
build: do not lint built CSS files
7efac71 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
build: include license for source maps during build
a98339b 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(REUSE): add /css
4f3ad57 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(REUSE): add js/vendor.LICENSE.txt to REUSE.toml
03d4837 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore: recompile assets
96fc693 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
Merged
Antreesy
Antreesy approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tested, works fine. Changes also look valid. Thanks!

@Antreesy Antreesy mentioned this pull request Aug 13, 2024
Closed
@Antreesy Antreesy merged commit bd7d7e3 into master Aug 14, 2024
43 checks passed
@Antreesy Antreesy deleted the build/vite branch August 14, 2024 15:04
@Antreesy
Copy link
Collaborator

/backport to stable30

@backportbot backportbot bot mentioned this pull request Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

@nickvergessen nickvergessen Awaiting requested review from nickvergessen nickvergessen is a code owner

Assignees

@ShGKme ShGKme

Labels
3. to review bug performance
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
3 participants
@ShGKme @nickvergessen @Antreesy