Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable24] Fix background email job for disabled users #1256

Merged
merged 3 commits into from
Aug 26, 2022
Merged

[stable24] Fix background email job for disabled users #1256

merged 3 commits into from
Aug 26, 2022

Conversation

nickvergessen
Copy link
Member

Backport of #1255

@nickvergessen
Only update the next_send_time for disabled users when the time was r…
43d4048 
…eached

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Add a migration to reset the next send for disabled users
3c77d2f 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Bump version
ae19104 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 24.0.5 milestone Aug 26, 2022
PVince81
PVince81 approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9618 was 9300 (+3.41%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen nickvergessen merged commit c04ee7c into stable24 Aug 26, 2022
@nickvergessen nickvergessen deleted the backport/1255/stable24 branch August 26, 2022 07:18
@blizzz blizzz mentioned this pull request Aug 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees
No one assigned
Labels
3. to review bug feature: email reminder ✉️
Projects
None yet
Milestone
Nextcloud 24.0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @PVince81