[stable10] Switch notification icon to dark if theming app is using bright colors #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested and works 👍 |
|
Can this be merged @juliushaertl ? |
|
Okay, just tested, seems to work in the basics, but when changing the color on the fly (for the admin) it fails to switch icons, |
nickvergessen
force-pushed
the
stable10-backport-9
branch
from
df53466
to
eebe641
Compare
|
@nickvergessen yes, should be ok. Right, the preview for the icon isn't working, but this need some more time. I'm still not sure how to solve this. |
|
Thanks for the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #9