Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fair use of push notifications #1098

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Fair use of push notifications #1098

merged 2 commits into from
Oct 25, 2021

Conversation

nickvergessen
Copy link
Member

We want to keep offering our push notification service for free, but large
users overload our infrastructure. For this reason we have to rate-limit the
use of push notifications. If you need this feature, consider setting up your
own push server or using Nextcloud Enterprise.

Signed-off-by: Joas Schilling coding@schilljs.com

@skjnldsv
Copy link
Member

/rebase

We want to keep offering our push notification service for free, but large
users overload our infrastructure. For this reason we have to rate-limit the
use of push notifications. If you need this feature, consider setting up your
own push server or using Nextcloud Enterprise.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@skjnldsv
Copy link
Member

> psalm --threads=1
Scanning files...
Analyzing files...

░░░░░░░░░░░░░░░░░░░░░░░░░░

ERROR: UndefinedInterfaceMethod - lib/Command/TestPush.php:88:36 - Method OCP\Notification\IManager::isFairUseOfFreePushService does not exist (see psalm.dev/181)
		if (!$this->notificationManager->isFairUseOfFreePushService()) {


ERROR: UndefinedInterfaceMethod - lib/Push.php:298:36 - Method OCP\Notification\IManager::isFairUseOfFreePushService does not exist (see psalm.dev/181)
		if (!$this->notificationManager->isFairUseOfFreePushService()) {


------------------------------
2 errors found
------------------------------
88 other issues found.
You can display them with --show-info=true
------------------------------
Psalm can automatically fix 2 of these issues.
Run Psalm again with 
--alter --issues=MissingReturnType --dry-run
to see what it can fix.
------------------------------

Checks took 15.39 seconds and used 668.778MB of memory
Psalm was able to infer types for 94.1871% of the codebase
Script psalm --threads=1 handling the psalm event returned with error code 2
Error: Process completed with exit code 2.

@nickvergessen
Copy link
Member Author

Yeah christoph lib needs a bump

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit 298c227 into master Oct 25, 2021
@nickvergessen nickvergessen deleted the fair-use-push branch October 25, 2021 08:23
@skjnldsv skjnldsv mentioned this pull request Oct 25, 2021
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants