-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sign final payload #1081
sign final payload #1081
Conversation
Returned signature did not match payload as it was changed after signing. Signed-off-by: Martin Zimmermann <martin.zimmermann@bytepoets.com>
I will check it next week with Ivan to confirm it's not breaking device and also to check why the mobile apps didn't complain so far XP |
Maybe I didn't unterstand the verification part. But I am not able to verify the signature. It works when I actually sign the final payload. Is the signature verification by any means necessary to verify the response? |
Well the mobile apps can verify it to make sure the data is correct before passing the information on to the push proxy. |
A checksum should be enough for that purpose. I forgot to add the commands to verify the response as I am still unsure if I do it just wrong:
This returns
Now, you can use The command to verify data is: |
I wrote an integration test and could confirm the issue. I pushed it to #1094 together with your commit and a fix for the failing unit tests, so let's continue it there. |
Thanks! |
Returned signature did not match payload as it was changed after signing.