Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont load UI on embedded pages #1013

Merged
merged 2 commits into from
Jun 18, 2021

Conversation

nickvergessen
Copy link
Member

Fix #1012

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@juliusknorr juliusknorr force-pushed the bugfix/1012/dont-load-ui-on-embedded-pages branch from 9bf8574 to d5183d8 Compare June 18, 2021 11:55
@juliusknorr
Copy link
Member

Ammended the php-cs fix

@nickvergessen nickvergessen merged commit 6a74ba3 into master Jun 18, 2021
@nickvergessen nickvergessen deleted the bugfix/1012/dont-load-ui-on-embedded-pages branch June 18, 2021 13:53
@Cyrille37
Copy link

Hello

As I said (ask) in #1012 perhaps it depends of the user status while visiting a page with embedded Nextcloud stuff:

  • if an anonymous user, don't need to load UI
  • but it could be useful for a Nextcloud logged-in user

@nickvergessen
Copy link
Member Author

If we don't load with RENDER AS USER, the UI has no point to tangle itself to. So that works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

public embed call notification api endpoint
3 participants