-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quickfix for action button and material design icon #1614
Quickfix for action button and material design icon #1614
Conversation
07896a5
to
0ddf83c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
@PVince81 I agree that 18 or 20 would look better, but for now 16px is our default in Nextcloud. We can talk about bumping that up a bit but I wouldn't do it here. |
ok, fine. adjusted. please review |
When using a material design icon in the icon slot, this fix will properly align it vertically. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Since 16px is an existing default, let's use that in the recommendation for when using material design icons in the ActionButton. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2178912
to
3446414
Compare
rebased for cypress fix |
When using a material design icon in the icon slot, this fix will
properly align it vertically.
We need it because the ActionButton consumer cannot override the styles with
::v-deep
since the popover itself might be in the document bodyWhen testing the docs you might need to scroll up or down to see the dropdown because of nextcloud/server#23872 which also occurs in the docs...