-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action button out of the box support for vue material design icons #1613
Comments
it appears that setting "vertical-align: middle" on the svg centers it correctly. so we should add a rule for it. |
I guess even better would be to have a property |
PR here for a quick fix: #1614 we need it because the ActionButton consumer cannot override the styles with |
I talked about this with @ma12-co in the past and I cannot see a way we can make this happen without bundling all material design icons in the library. What we would need is a way to let the library keep those as as es6 imports so that they would be bundled by the app in the end somehow, but I could figure out any way to do so. Though I'd say that is something for a separate issue if we really want to tackle it at some point. |
Fixed by #1614 |
As I understood, we want to move to material design icons as per #1051
Currently when using icons from the vue material design icons library, the style doesn't fit:
This is an action button inside a menu (on my branch nextcloud/spreed#4569):
where Hand comes from
import Hand from 'vue-material-design-icons/Hand'
With the above, the menu looks like this:
it is not centered, probably because of background-size not being usable with that svg element.
I tried bumping its size to 44px to match the other icon sizes but then the hand becomes huge:
In any case, as a consumer I shouldn't have to tinker with the styles.
Ideally we could define some styles that are based on the generated "material-design-icon" SVG.
The text was updated successfully, but these errors were encountered: