Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Make BasicAuth Credentials less important in subscription form (but also visible) #488

Merged
merged 1 commit into from
Apr 10, 2019
Merged

UI: Make BasicAuth Credentials less important in subscription form (but also visible) #488

merged 1 commit into from
Apr 10, 2019

Conversation

rponline
Copy link

@rponline rponline commented Apr 7, 2019 •
edited
Loading

Since the BasicAuth credentials were the only "Advanced settings", i removed the Advanced settings Button and added a credentials Checkbox instead.

This change makes the interface clearer.

Screen Shot 2019-04-07 at 16 13 39
Screen Shot 2019-04-07 at 16 13 57

Technically, the Advanced settings string is not used anymore. I didn't delete the transaltions yet.
Should I?

@Grotax Grotax self-requested a review April 9, 2019 17:04
Grotax
Grotax approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@Grotax Grotax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)
I think we should keep the "Advanced settings" translation string.
If you are interested there are more ui-related issues ;)

@Grotax Grotax merged commit 6876dd1 into nextcloud:master Apr 10, 2019
Grotax added a commit that referenced this pull request Apr 10, 2019
@Grotax
Release 13.1.6
5bfcb8e 
Changed
- Replaced "Advanced settings" for feed credentials by a checkbox #488

Fixed
- Fixed signature error caused by favicon cache #485
@Grotax Grotax mentioned this pull request Apr 10, 2019
Merged
@rponline
Copy link
Author

@Grotax You mean rewriting the UI in Vue? :D

Since I use Nextcloud on my own and wish to use it in the organizations I'm working in, I want to spend more time polishing the UI and so on.

For now I concentrate on little tasks. My focus is on UI/HTML/CSS.
I have some trouble working with JS async/promises, vuex, getters&setters etc ... but i hope i will learn a lot working on NC projects :)

Grotax added a commit that referenced this pull request Apr 11, 2019
@Grotax
Release 13.1.6
3626bce 
Changed
- Replaced "Advanced settings" for feed credentials by a checkbox #488

Fixed
- Fixed signature error caused by favicon cache #485
Grotax added a commit that referenced this pull request Apr 11, 2019
@Grotax
Release 13.1.6 (#490)
66f81ea 
Changed
- Replaced "Advanced settings" for feed credentials by a checkbox #488

Fixed
- Fixed signature error caused by favicon cache #485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grotax Grotax Grotax approved these changes

Assignees
No one assigned
Labels
design enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rponline @Grotax