-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nextcloud): Add low-level helpers for WebDavResponse #2561
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## test/nextcloud/all-props-parsed #2561 +/- ##
===================================================================
- Coverage 28.71% 28.71% -0.01%
===================================================================
Files 366 366
Lines 136274 136280 +6
===================================================================
Hits 39128 39128
- Misses 97146 97152 +6
*This pull request uses carry forward flags. Click here to find out more.
|
I was also thinking a lot about removing the webdav file abstraction and rather have something based on package:file in a separate repo. Is there a way we can do this without breaking the api? |
Sounds good, but the nextcloud package wouldn't know about this abstraction, right?
I need to get rid of this for CalDAV/CardDAV support, so if we deprecate it now we will have to wait a lot longer until we can support those as well. |
For the idea I head yes.
Then just duplicate the code and implement the new low level api separately. |
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
…pers Signed-off-by: provokateurin <kate@provokateurin.de>
efc8823
to
81ab415
Compare
Necessary refactor for #718.
Extension helpers are still there to offload the small part of logic that is useful for consumers (while the rest was just proxy variables).