-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nextcloud)!: Move RichObjectParameter from spreed to core and fix rich parameter typing for broken apps #2501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not ideal, that we lose the typing on the spreed and notifications :(
LGTM overall, please just address the small parsing issue.
packages/neon_framework/packages/talk_app/lib/src/widgets/rich_object/file.dart
Outdated
Show resolved
Hide resolved
fd89c64
to
37b5bb5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2501 +/- ##
==========================================
- Coverage 30.27% 28.37% -1.90%
==========================================
Files 352 352
Lines 124321 135904 +11583
==========================================
+ Hits 37632 38560 +928
- Misses 86689 97344 +10655
*This pull request uses carry forward flags. Click here to find out more.
|
… rich parameter typing for broken apps Signed-off-by: provokateurin <kate@provokateurin.de>
37b5bb5
to
f4fd9cf
Compare
Split off from #2456
I squashed the previously separate commits as they need each other to make sense.