-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(neon_framework): add account_repository #2403
Conversation
packages/neon_framework/packages/account_repository/lib/src/account_repository.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only reviewed the account_repository so far.
I'll review the neon_framework changes when the existing comments have been sorted out.
IMO you should add a verify for all the API calls that are made in the tests.
packages/neon_framework/packages/account_repository/analysis_options.yaml
Outdated
Show resolved
Hide resolved
packages/neon_framework/packages/account_repository/lib/src/account_repository.dart
Show resolved
Hide resolved
packages/neon_framework/packages/account_repository/lib/src/account_repository.dart
Show resolved
Hide resolved
packages/neon_framework/packages/account_repository/lib/src/account_repository.dart
Outdated
Show resolved
Hide resolved
packages/neon_framework/packages/account_repository/lib/src/account_repository.dart
Outdated
Show resolved
Hide resolved
packages/neon_framework/packages/account_repository/test/account_repository_test.dart
Outdated
Show resolved
Hide resolved
packages/neon_framework/packages/account_repository/test/account_storage_test.dart
Outdated
Show resolved
Hide resolved
packages/neon_framework/packages/account_repository/test/account_storage_test.dart
Outdated
Show resolved
Hide resolved
packages/neon_framework/packages/account_repository/test/account_storage_test.dart
Outdated
Show resolved
Hide resolved
packages/neon_framework/packages/account_repository/test/models/credentials_test.dart
Outdated
Show resolved
Hide resolved
d14008c
to
97eb9bd
Compare
I've dropped the neon_framework changes for easier reviewability. |
97eb9bd
to
4b0bf6d
Compare
Thanks for mentioning. I've added them everywhere. |
05efad7
to
ceffbdc
Compare
packages/neon_framework/packages/account_repository/test/account_repository_test.dart
Show resolved
Hide resolved
7c65257
to
750e590
Compare
Please review my latest changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In many places you are using await expectLater()
, but it is unnecessary because you already match using completion()
.
packages/neon_framework/packages/account_repository/lib/src/account_repository.dart
Outdated
Show resolved
Hide resolved
packages/neon_framework/packages/account_repository/lib/src/utils/http_client_builder.dart
Outdated
Show resolved
Hide resolved
packages/neon_framework/packages/account_repository/lib/src/account_repository.dart
Show resolved
Hide resolved
packages/neon_framework/packages/account_repository/test/account_repository_test.dart
Show resolved
Hide resolved
packages/neon_framework/packages/account_repository/test/account_repository_test.dart
Show resolved
Hide resolved
packages/neon_framework/packages/account_repository/test/account_repository_test.dart
Outdated
Show resolved
Hide resolved
packages/neon_framework/packages/account_repository/test/account_repository_test.dart
Outdated
Show resolved
Hide resolved
packages/neon_framework/packages/account_repository/test/utils/http_client_builder_test.dart
Outdated
Show resolved
Hide resolved
750e590
to
b120fc3
Compare
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Future code refactors will access individual clients directly so the script can no longer check them. Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
b120fc3
to
61963b5
Compare
No this will not work as the verify calls would be invoked before the actual call completes.
|
Oh but then there are some places were you use completion() without await expectLater() |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2403 +/- ##
==========================================
+ Coverage 26.32% 26.40% +0.08%
==========================================
Files 362 370 +8
Lines 136541 136662 +121
==========================================
+ Hits 35940 36086 +146
+ Misses 100601 100576 -25
*This pull request uses carry forward flags. Click here to find out more.
|
packages/neon_framework/packages/account_repository/test/account_repository_test.dart
Outdated
Show resolved
Hide resolved
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
61963b5
to
be66e4b
Compare
Finally a end to end unit tested login flow.
neon_framework
is good enough. I don't want too many types (open for discussions)