-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to nextcloud/vue 8 #9144
Conversation
For a reviewable upgrade, I would suggest to clean up our code from removed components while staying on the old nc/vue, then bump the lib and do the rest of the changes. Something like
|
i have started that one: its almost done, need to rebase it and thats it think: #8814 |
cf98fc5
to
bcbccb6
Compare
Lets merge this one and close mine #8814 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane but didn't test yet
Any strong reason for aliasing NcSelect to SelectVue?
src/views/Setup.vue
Outdated
@@ -71,4 +71,8 @@ export default { | |||
.mail-empty-content { | |||
margin: 0 auto; | |||
} | |||
.empty-content { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: BEM and getting rid of the mail-empty-content container
Select tag already exists in Html, and Not NcSelect just because we're already aliasing other components, so to keep it consistent |
For consistency with other apps and the upstream name I would prefer NcSelect |
still to do? |
Done, but I couldn't mimic the old behaviour tho, might still need improvements. |
0057758
to
7fd347d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and rebased, changed 2 small things
7fd347d
to
cb10622
Compare
#9144 (comment) is still there and a blocker edit: seems fixed. I was not on the latest commit. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
If the color is coming from nc/vue for any active element then I assume this must have a purpose. Let's keep it but make the text readable. |
4339dd7
to
deb9626
Compare
|
deb9626
to
356727d
Compare
closed accidentally, because it was mentioned as a fix on the nc/vue pr. sorry about that :) |
356727d
to
21cdaf3
Compare
21cdaf3
to
fd2bdc4
Compare
i tested all what i could. The PR is huge, im sure we will miss something anyway. The most commonly used actions work fine. |
Signed-off-by: hamza mahjoubi <hamzamahjoubi221@gmail.com>
8a2ffd3
to
de995ed
Compare
Composer state : I couldn't replicate the unwrapped state we had with the counter