Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): allow date and recipient search #9002

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

JohannesGGE
Copy link
Contributor

@JohannesGGE JohannesGGE commented Oct 25, 2023

Fix: #8864
Server PR: nextcloud/server#40618


Currently it's either possible to provide email: (will be mapped from person) or from:/to:/cc:/bcc:. email will search in all fields (or), from/to/cc/bcc in the explicit field (and). If both filter types are provided email will be used.

How to test

curl -u admin:admin https://localhost/ocs/v2.php/search/providers/mail/search?term=spam&person=nc-user_admin

Open Questions:

  • What does the person filter provide exactly? An IUser

ToDos:

  • Get email addresses for person (depends on what person provide

Follow-ups

@JohannesGGE JohannesGGE self-assigned this Oct 25, 2023
@JohannesGGE JohannesGGE removed their assignment Oct 31, 2023
@ChristophWurst ChristophWurst changed the title feat(advanced-search): allow date and recipient search feat(search): allow date and recipient search Nov 8, 2023
@ChristophWurst
Copy link
Member

I think the API is implemented correctly. Can't test it right now because searching for since:1699474523 doens't end up in Mail's search provider. Neither does in:mail since:1699474523 🤷

Signed-off-by: Johannes Merkel <mail@johannesgge.de>
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@ChristophWurst ChristophWurst merged commit 0ce59ec into main Nov 14, 2023
30 of 31 checks passed
@ChristophWurst ChristophWurst deleted the feat/8864/advanced-search branch November 14, 2023 13:15
Copy link

github-actions bot commented Apr 5, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔎 Allow message date and recipient search in advanced search
4 participants