feat: add snooze mvp #8694
Merged
feat: add snooze mvp #8694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return new JSONResponse([], Http::STATUS_FORBIDDEN); | ||
| } | ||
|
|
||
| $this->snoozeService->snoozeThread($selectedMessage, $unixTimestamp); |
There was a problem hiding this comment.
pretty cool that a whole thread can be snoozed as well :)
ChristophWurst
approved these changes
Aug 10, 2023
Comment on lines
+86
to
+90
| $rows = array_map(static function (array $row) { | ||
| return [ | ||
| 'messageId' => (string)$row[0] | ||
| ]; | ||
| }, $result->fetchAll(\PDO::FETCH_NUM)); |
There was a problem hiding this comment.
| use OCP\Migration\IOutput; | ||
| use OCP\Migration\SimpleMigrationStep; | ||
|
|
||
| class Version3300Date20230807300513 extends SimpleMigrationStep { |
There was a problem hiding this comment.
Suggested change
| class Version3300Date20230807300513 extends SimpleMigrationStep { | |
| class Version3400Date20230807300513 extends SimpleMigrationStep { |
because the next minor will be 3.4. 3.3 has already been branched off
ChristophWurst
approved these changes
Aug 10, 2023
JohannesGGE
force-pushed
the
enh/2048/snooze-mvp
branch
from
be3fbdd
to
bbda253
Compare
|
😬 needs rebase onto latest main to get rid of the conflicts |
JohannesGGE
force-pushed
the
enh/2048/snooze-mvp
branch
5 times, most recently
from
f882dd2
to
26de4f8
Compare
| 'length' => 4, | ||
| ]); | ||
| $messagesRetentionTable->setPrimaryKey(['id'], 'mail_msg_snoozed_id_idx'); | ||
| $messagesRetentionTable->addIndex(['message_id'], 'mail_msg_snoozed_msgid_idx'); |
There was a problem hiding this comment.
should we make it unique? two entries don't make any sense
Otherwise
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
JohannesGGE
force-pushed
the
enh/2048/snooze-mvp
branch
from
26de4f8
to
e16b6a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2048