Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unread counter position for outbox #7778

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Fix unread counter position for outbox #7778

merged 1 commit into from
Jan 10, 2023

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Dec 15, 2022 •
edited by st3iny
Loading

@GretaD GretaD self-assigned this Dec 15, 2022
ChristophWurst
ChristophWurst approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 one :deep less

@GretaD GretaD force-pushed the fix/outbotx-unread-counter branch 2 times, most recently from 5289e77 to 137e907 Compare December 16, 2022 14:40
@GretaD
Copy link
Contributor Author

GretaD commented Dec 16, 2022

after this #7694 got merged now i need to change the margin again. Possibly it will need a fix up after this gets released: nextcloud-libraries/nextcloud-vue#3572

st3iny
st3iny previously approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Nc-vue 7.3 was released in the meantime.

@st3iny st3iny dismissed their stale review January 6, 2023 14:06

Update of nc-vue is still pending.

@st3iny
Copy link
Member

st3iny commented Jan 6, 2023

Requires #7838.

@GretaD GretaD requested a review from st3iny January 6, 2023 15:14
@GretaD @st3iny
Fix unread counter position for outbox
1d68a52 
Signed-off-by: greta <gretadoci@gmail.com>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny enabled auto-merge January 10, 2023 11:16
@st3iny st3iny added this to the v2.3.0 milestone Jan 10, 2023
@st3iny
Copy link
Member

st3iny commented Jan 10, 2023

/backport to stable2.2

@st3iny st3iny merged commit 9538abe into main Jan 10, 2023
@st3iny st3iny deleted the fix/outbotx-unread-counter branch January 10, 2023 11:24
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 10, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@st3iny st3iny st3iny approved these changes

Assignees

@GretaD GretaD

Labels
4. to release bug design
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@GretaD @st3iny @ChristophWurst